Performance scripts don't account for restore operation failures

[nkolev92]

Currently the performance scripts will not report in any way, shape or form that an operation failed.
While most of our test cases are set-up in a way that doesn't fail, but sitll makes investigations when failures do occur, quite a pain :)

[mfkl]

Somewhat related: Running the perf script in a non elevated PS prompt sometimes gives

Access to the path 'C:\Program Files\dotnet\sdk\NuGetFallbackFolder\microsoft.netcore.platforms\1.1.0\.nupkg.metadata' is denied.
Access to the path 'C:\Program Files\dotnet\sdk\NuGetFallbackFolder\microsoft.netcore.targets\1.1.0\.nupkg.metadata' is denied.

[nkolev92]

Ah, interesting.

I've never run into that for our test repros.
The fallback folder is not used in 3.x and later, so maybe that's why.

[zivkan]

@mfkl that's not a bug in the perf script, it's a bug in your branch where you change the .nupkg.metadata file last write time. Your branch doesn't account for the difference between global packages folder (where we can safely assume there is write access) and fallback folder (which often is read-only). This is something that would need to be fixed before we can merge, assuming we get the perf impact to an acceptable level.