Add missing supported MSBuild versions #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
approved these changes
Jan 8, 2019
| @@ -5254,7 +5254,7 @@ nuget update -Self</value> | |||
| <value>A list of package sources to use as fallbacks for this command.</value> | |||
| </data> | |||
| <data name="CommandMSBuildVersion" xml:space="preserve"> | |||
| <value>Specifies the version of MSBuild to be used with this command. Supported values are 4, 12, 14. By default the MSBuild in your path is picked, otherwise it defaults to the highest installed version of MSBuild.</value> | |||
| <value>Specifies the version of MSBuild to be used with this command. Supported values are 4, 12, 14, 15.1, 15.3, 15.4, 15.5, 15.6, 15.7, 15.8, 15.9. By default the MSBuild in your path is picked, otherwise it defaults to the highest installed version of MSBuild.</value> | |||
There was a problem hiding this comment.
As this will ship in 5.0 (by which 16.0 will be release), can you please add that as well.
We need a better way of communicating this (an auto-gened list would work), but versions getting skipped such as 15.2 is a problem.
It's fine for now.
nkolev92
requested review from
heng-liu,
jainaashish,
PatoBeltran,
dominoFire and
zivkan
devlead
force-pushed
the
feature/msbuildversionhelp
branch
from
96baa9b
to
a7964dc
Compare
|
What about a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command line help only lists 4, 12, 14 as supported MSBuild versions, but if you have one of 15.1, 15.3, 15.4, 15.5, 15.6, 15.7, 15.8, 15.9 installed, they'll also work.
Relates to i.e. NuGet/docs.microsoft.com-nuget#1250, NuGet/Home#5170, NuGet/Home#4941