-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing supported MSBuild versions #2673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @devlead
Can you please make the small change I asked for.
@@ -5254,7 +5254,7 @@ nuget update -Self</value> | |||
<value>A list of package sources to use as fallbacks for this command.</value> | |||
</data> | |||
<data name="CommandMSBuildVersion" xml:space="preserve"> | |||
<value>Specifies the version of MSBuild to be used with this command. Supported values are 4, 12, 14. By default the MSBuild in your path is picked, otherwise it defaults to the highest installed version of MSBuild.</value> | |||
<value>Specifies the version of MSBuild to be used with this command. Supported values are 4, 12, 14, 15.1, 15.3, 15.4, 15.5, 15.6, 15.7, 15.8, 15.9. By default the MSBuild in your path is picked, otherwise it defaults to the highest installed version of MSBuild.</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this will ship in 5.0 (by which 16.0 will be release), can you please add that as well.
We need a better way of communicating this (an auto-gened list would work), but versions getting skipped such as 15.2 is a problem.
It's fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 added.
96baa9b
to
a7964dc
Compare
What about a |
Command line help only lists 4, 12, 14 as supported MSBuild versions, but if you have one of 15.1, 15.3, 15.4, 15.5, 15.6, 15.7, 15.8, 15.9 installed, they'll also work.
Relates to i.e. NuGet/docs.microsoft.com-nuget#1250, NuGet/Home#5170, NuGet/Home#4941