The SDK Resolver should call DirectoryUtility.CreateSharedDirectory when meddling with the temp folder #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
requested review from
aortiz-msft,
cristinamanum,
dominoFire,
donnie-msft,
dtivel,
heng-liu,
kartheekp-ms,
rrelyea,
zivkan and
zkat
as code owners
zivkan
approved these changes
Feb 25, 2020
dtivel
approved these changes
Feb 25, 2020
src/NuGet.Core/Microsoft.Build.NuGetSdkResolver/RestoreRunnerEx.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.Tests/Microsoft.Build.NuGetSdkResolver.Tests/RestoreRunnerExTests.cs
Show resolved
Hide resolved
nkolev92
deleted the
dev-nkolev92-ResolverCreateFolderWithOpenPermissions
branch
nkolev92
added a commit
that referenced
this pull request
Feb 25, 2020
…hen meddling with the temp folder (#3264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#9199
Regression: Yes
Fix
Details:
This caused a permissions problem with the resolver on linux where, because the temp folder is machine-wide while the restore process was running without admin permissions.
Note that this is a regression and ideally is reviewed with high priority :)
Note that this is an imperfect and temporary change and will go to 5.5, For 5.6 #3261 is the solution.
/cc @JohnTortugo Can we give you a build for you to test?
Testing/Validation
Tests Added: Yes/No
Reason for not adding tests:
Validation: