Enforce whitespace in ruleset

[nkolev92]

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/1041

Regression? Last working version:

Description

This is meant to complement the dotnet format check we have in the CI.

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[nkolev92]

The reason why these warnings are suppressed in this project is the fact that we're using submodules and not the packages, NuGet/Home#2345, so we don't have control over all of the code.

[zivkan]

Trailing whitespace at the end of a line annoys me much more than it should, so I completely approve of this PR 👍

[nkolev92]

Something's off with the apex machines :/

It suggests that it's usually an issue due to the analyzers not being in sync with the tooling version, but I haven't noticed that being the case.

After all, E2E tests run on the same machines as well.

[zivkan]

E2E job doesn't compile anything, it downloads artifacts created by the build + unit test job, whereas Apex job compiles the test binary, in addition to running the tests.

I noticed that it's using VS 2019 to compile the test binaries, and using the latest .net 6 preview that VS 2022 installs. Perhaps the .net 6 SDK is no longer compatible with msbuild 16, and the msbuild/.net sdk teams didn't set up the SDK resolver correctly to account for this? Perhaps worth checking with them. You can also try locally, to confirm if you get the same behaviour on your machine. Maybe we need up to update VS 2022 (& .net 6 sdk) on the CI machines.

[nkolev92]

That's great info thanks @zivkan

I'll try to investigate that soon.

[ghost]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

[ghost]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

[ghost]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.