Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Stop using FileSystem and Common submodules (#4536)" #4595

Merged

Conversation

erdembayar
Copy link
Contributor

@erdembayar erdembayar commented Apr 27, 2022

This reverts commit cebb690.

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/1581

Regression? Last working version:

Description

cebb690 introduced NGen failure, need binding redirect to fix.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@erdembayar erdembayar requested a review from a team as a code owner April 27, 2022 16:22
@nkolev92 nkolev92 merged commit 5ac16d7 into dev Apr 27, 2022
@nkolev92 nkolev92 deleted the dev-eryondon-revert-StopUsingFileSystemCommonsubmodules branch April 27, 2022 16:46
jeffkl added a commit that referenced this pull request May 2, 2022
Revert "Revert "Stop using FileSystem and Common submodules (#4536)" (#4595)"

This reverts commit 5ac16d7.
jeffkl added a commit that referenced this pull request Nov 1, 2022
Revert "Revert "Stop using FileSystem and Common submodules (#4536)" (#4595)"

This reverts commit 5ac16d7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants