Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes hardcoded strings in nuget.exe help command #4780

Merged
merged 4 commits into from
Sep 1, 2022

Conversation

dominoFire
Copy link
Contributor

@dominoFire dominoFire commented Aug 31, 2022

Bug

Fixes: NuGet/Home#12067

Regression? No Last working version: N/A

Description

Moves hardcoded strings from nuget.exe help command to a proper string resource.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added: Updated 1 test. Added 1 new test.
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled: Since a new string is added for -help option, we may need to update -help option in all doc pages.
    • OR
    • N/A

Validation

Image below shows nuget.exe help command wit a Before/After comparison

Left: Before
Right: After, help option has a different text.

image

@dominoFire dominoFire requested a review from a team as a code owner August 31, 2022 08:07
jeffkl
jeffkl previously approved these changes Aug 31, 2022
@dominoFire dominoFire dismissed stale reviews from donnie-msft and jeffkl via ec4f0d0 August 31, 2022 20:36
@dominoFire dominoFire requested review from jeffkl, donnie-msft and a team August 31, 2022 20:37
@dominoFire dominoFire merged commit 95be29c into dev Sep 1, 2022
@dominoFire dominoFire deleted the dev-dominofire-localize-nugetexe-help branch September 1, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuget.exe help command has unlocalized strings
4 participants