.NET 8 SDK: enable signed package verification by default on Linux #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
previously approved these changes
Jan 12, 2023
dtivel
force-pushed
the
dev-dtivel-enable-by-default
branch
from
86af347
to
6054803
Compare
erdembayar
approved these changes
Jan 13, 2023
donnie-msft
approved these changes
Jan 13, 2023
jeffkl
approved these changes
Jan 17, 2023
|
Does the .NET 8 overall plan include the split of the CTL into two files? As I recall, the lack of that approach was the problem we ran into earlier. |
|
@richlander, yes, .NET 8 SDK already has the 2 separate CTL files, as described here. |
dtivel
added a commit
that referenced
this pull request
Jan 27, 2023
dtivel
added a commit
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11262
Regression? Last working version:
Description
This change re-enables signed package verification by default on Linux for .NET 8 SDK Preview 1. Verification remains disabled by default on macOS.
With this .NET 7 SDK-era change, there are no known major blockers to enabling verification by default on Linux. As always, the
DOTNET_NUGET_SIGNATURE_VERIFICATIONenvironment variable provides an escape hatch, if necessary.CC @aortiz-msft, @skofman1, @richlander
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation