Fix issue with solution filters not restoring when in different folder than referenced solution #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerhon
changed the title
|
@dotnet-policy-service agree company="NAU Country Insurance" |
ghost
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
|
Anything else I need to do to move forward on this fix? I see some unit tests failed, anything I can do about those? The links to the failures take me to a private Azure DevOps instance. |
ghost
removed
the
Status:No recent activity
|
@jerhon I'll help take a look at the failing tests, but first could you rebase your branch? It may be due to some CI issue we fixed since your last rebase. Thanks! |
…ed by msbuild rather than path math based on the solution file directory.
…t both packages to be available.
|
@donnie-msft Done. |
donnie-msft
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12562
Regression? Last working version: n/a
Description
This is a bug fix that allows restoration of nuget packages for solution filters in directories other than the referenced solution file. A repo of the issue can be found in this Git repository: https://github.com/jerhon/nuget-slnf-bug
This changes the paths used to restore projects to be determined by the AbsolutePath reported by the MSBuild SDK on the ProjectFile rather than doing path math on the directory of the passed in file and the relative path reported by MSBuild.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation