Add option to disable all strong name signing during build of NuGet.Client repository

[jeffkl]

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/2790

Regression? Last working version:

Description

This change makes it possible to build our repository without any strong name signing enabled via SkipSigning=true. This will allow us to have a build pipeline that doesn't require disabling strong name validation and external contributors can build and run tests easier.

• Moved all of the InternalsVisibleTo logic from AssemblyInfo.cs to the projects so we can adjust the public key token depending on if strong name signing is enabled
• Added a new strong name key to sign tests with so that all InternalsVisibleTo are using the same public key.
• Updated logic used during ILMerge to use the same key as the containing project.

This doesn't currently change any behavior other than tests using a different key. You can just now build with /property:SkipSigning=true at the command-line to build without any signing.

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[zivkan]

build.ps1 override these when -SkipDelaySign was passed as an argument. It should be updated.

It possibly also makes this PR redundant, since there's already a different way to achieve the same outcome?

[jeffkl]

Thanks for pointing that out. I've updated the script to set SkipSigning=true to just disable all strong name signing. This pull request will make it easier for our CI on all platforms to disable signing. I'm thinking in the near future to instead use SignType values of None (default), Test, and Real. This would be more in line with MicroBuild. But from a developer's perspective, we just build and run tests. I need to find a way to make it so we don't have to do anything special to debug our VSIX (if possible) and have the default signing to None. Otherwise I'll default signing to "Test" which will delay sign things and require strong name signing validation exclusions. But for Linux and Mac CI, we'll just build and run tests as unsigned.

[zivkan]

• PR has a meaningful title

it does not at the moment.

[jeffkl]

Official build is now passing: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=9389345

I also verified a few assemblies to make sure their public key token didn't change. We can merge this and if it causes any issues we just can just revert and try again.