Build NuGet from the VMR

[mmitche]

Bug

N/A

Description

Changes to enable building of NuGet in the VMR in the windows and Linux builds (in non-source-only modes). Highlights:

• Update to a newer arcade, and update the property property usage in this repo to match
• Update build scripts to enable non-source-only builds
• Cleanup the SB wrapper project. Previously theree was actually no pre-built detection going on
• Add windows builds scripts.

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[mmitche]

A bit more verification to do here.

[nkolev92]

I'm confused as to why we need all these.
Aren't the projects scoped down differently?

I think we can probably solve this in a different file where it affects all projects in the src/NuGet.Clients subfolder.

[nkolev92]

I can probably make that change myself, if you prefer not add more complications in this PR.

[mmitche]

The issue is that these projects don't build properly in the VMR in non-source-only modes. I think typically in non-Windows cases. The goal is to exclude as little as possible from the default repo build in VMR modes. This is the only case of this. The rest of the Exclude* are just changing the source-only exclusion property to match the new name.

[nkolev92]

I noticed the prop change, I was more thinking that we shouldn't have to mark each individual project, since source build only cares about nuget.core projects with the exception of NuGet.PackageManagement, so there should be easier ways to do this (example, directory.build.props).

[mmitche]

Generally, we've tried to avoid proactively trimming down the set of projects to build, especially in non-source-only modes. My view is that the repo should mostly work 'stock', and we should avoid removing extras if not necessary.

If you want to stop building more projects, that's fine, but I think it's probably good that we only exclude 3 projects.

[mmitche]

@nkolev92 It looks like the test failures are unrelated

[nkolev92]

retriggered again.