Fixes for pack #606
Merged
Fixes for pack #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it only build once instead of twice when building symbols Use the correct version when passing a version or suffix to pack when a version is in the project.json file. Allow ..\..\files to get included in the pack.
| // Create a builder for the main package as well as the sources/symbols package | ||
| PackageBuilder mainPackageBuilder = factory.CreateBuilder(_packArgs.BasePath); | ||
| PackageBuilder mainPackageBuilder = factory.CreateBuilder(_packArgs.BasePath, version, _packArgs.Suffix, buildIfNeeded: true); |
There was a problem hiding this comment.
Can the NuGetVersion know about the suffix instead of passing the suffix along?
There was a problem hiding this comment.
I started doing something more like that, but you can pass in just a suffix and no version to pack while having a version in project.json. It needs to know that the version passed in was null but the suffix wasn't null. So it seemed that we needed to pass around both.
There was a problem hiding this comment.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it only build once instead of twice when building symbols.
Use the correct version when passing a version or suffix to pack when a version is in the project.json file.
Allow ....\files to get included in the pack. This was causing dlls to not get included when the output directory started with .....
@emgarten @spadapet @joelverhagen