Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Forcing HTTPS for the Search service #187

Merged
merged 9 commits into from
Jun 26, 2017
Merged

Forcing HTTPS for the Search service #187

merged 9 commits into from
Jun 26, 2017

Conversation

agr
Copy link
Contributor

@agr agr commented May 19, 2017

#3975

  • Added the configuration for forcing the HTTPS;
  • Added the ForceSslMiddleware from NuGet.Services.Owin;
  • Added functional tests.

@dnfclas
Copy link

dnfclas commented May 19, 2017

@agr,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@@ -73,6 +73,12 @@ public class Startup

_logger.LogInformation(LogMessages.AppStartup);

// redirect all HTTP requests to HTTPS
if (config.RequireSsl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

@skofman1
Copy link
Contributor

:shipit:

@agr agr merged commit bf167d4 into dev Jun 26, 2017
@agr agr deleted the dev-agr-3795-search branch June 26, 2017 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants