[MSA] Use EmailClaim instead of preferred_username during auth/register #7565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shishirx34
requested review from
cristinamanum,
dannyjdev,
joelverhagen,
loic-sharma,
ryuyu,
scottbommarito,
xavierdecoster and
zhhyu
as code owners
agr
reviewed
Sep 17, 2019
...allery.Facts/Authentication/Providers/CommonAuth/AzureActiveDirectoryV2AuthenticatorFacts.cs
Outdated
Show resolved
Hide resolved
agr
approved these changes
Sep 17, 2019
agr
reviewed
Sep 17, 2019
...vices/Authentication/Providers/AzureActiveDirectoryV2/AzureActiveDirectoryV2Authenticator.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #7324
Earlier we were using
preferred_usernameclaim as the email, from my initial observations it was working fine. However, for certain accounts(skype account used as MSA) thepreferred_usernamereturns the handle rather than email. This fix addresses the bug and also keeps consistent with the expected claims.