Use table-responsive for sample glob descriptions. #8974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
reviewed
Feb 1, 2022
| @@ -457,7 +457,7 @@ | |||
| <div class="panel-body"> | |||
| <p>A glob pattern allows you to replace any sequence of characters with '*'.</p> | |||
| <p>Example glob patterns:</p> | |||
| <table class="table table-condensed borderless"> | |||
| <table class="table-responsive table-condensed borderless"> | |||
There was a problem hiding this comment.
In the docs it mentions giving the parent element .table-response. Does this work just the same?
https://getbootstrap.com/docs/3.3/css/#tables-responsive
There was a problem hiding this comment.
That's a great question. I'll try this out too.
There was a problem hiding this comment.
Spoke with @joelverhagen "offline". It turns out that on the parent element, we have things that are not the table, so the behaviour is a little odd (scrollbar that can't be scrolled?). The current location has the behaviour we want to see (table resizes correctly to narrow window).
joelverhagen
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8919
This was being caused by a table in the API keys page being wider than the page when zoomed in.
This behaviour could also be replicated by making the window very narrow.
Update this table to use BootStrap's table-responsive, which causes the table content to correctly collapse with page width.