-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y] Read warning when tabbing to Paket CLI tab #9190
Conversation
document.querySelectorAll('pre code').forEach((el) => { | ||
hljs.highlightElement(el); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shishirx34 There was no change in lines 1345-1352. I am not sure why it is showing as a change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably it's because different format of space? you could redo change to this file and apply your changes. it probably could resolve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reapplied the change, but it did not affect the PR.
@camigthompson - can these be merged? |
Added
role = alert
to the warning below the Paket CLI command so that the screen reader will read the warning out to the user without having to tab to the warning element itself.Addresses #9172