Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Read warning when tabbing to Paket CLI tab #9190

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Conversation

keylime-unicorn
Copy link
Contributor

Added role = alert to the warning below the Paket CLI command so that the screen reader will read the warning out to the user without having to tab to the warning element itself.

Addresses #9172

@keylime-unicorn keylime-unicorn requested a review from a team as a code owner August 12, 2022 22:47
document.querySelectorAll('pre code').forEach((el) => {
hljs.highlightElement(el);
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the change here?

Copy link
Contributor Author

@keylime-unicorn keylime-unicorn Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shishirx34 There was no change in lines 1345-1352. I am not sure why it is showing as a change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably it's because different format of space? you could redo change to this file and apply your changes. it probably could resolve it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reapplied the change, but it did not affect the PR.

@shishirx34
Copy link
Contributor

@camigthompson - can these be merged?

@keylime-unicorn
Copy link
Contributor Author

Performed some validation and confirmed that the warning is read by the screen reader when Paket CLI tab is selected.

The current behavior when the Paket CLI tab is selected: (the warning is ignored by the screen reader)
warning-original

The new behavior when the Paket CLI tab is selected: (the warning is read out by the screen reader when Paket CLi tab is selected)
warning-new

@keylime-unicorn keylime-unicorn merged commit 6bae10c into dev Aug 19, 2022
@joelverhagen joelverhagen mentioned this pull request Aug 26, 2022
34 tasks
@joelverhagen joelverhagen deleted the a11y-warning branch August 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants