Refactored PackageService code for use by Search-by-TFM #9261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,113 @@ | |||
| using System; | |||
There was a problem hiding this comment.
this needs the .NET Foundation header
There was a problem hiding this comment.
I've added this in now
joelverhagen
previously approved these changes
Sep 29, 2022
dannyjdev
previously approved these changes
Sep 29, 2022
drewgillies
previously approved these changes
Sep 29, 2022
There was a problem hiding this comment.
My only thought is more of a discussion piece--the new class is named a service but doesn't really follow the DI service pattern that we generally use in gallery--it's a static type and not added to the DI container. So, possibly being pedantic, but I'd be more inclined to name this a "helper" rather than a "service" in this context.
advay26
dismissed stale reviews from drewgillies, dannyjdev, and joelverhagen
via
6de495f
joelverhagen
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/NuGet/Engineering/issues/4577
We need to reuse some asset framework logic from PackageService in NuGet.Jobs' Catalog2AzureSearch for Search-by-TFM, and moving this logic to NuGetGallery.Core would allow us to reuse this code with minimal changes.
This change:
All previous tests passed after this change.