Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dockerize #65

Merged
merged 13 commits into from
Feb 26, 2019
Merged

Feature/dockerize #65

merged 13 commits into from
Feb 26, 2019

Conversation

zero88
Copy link
Contributor

@zero88 zero88 commented Feb 21, 2019 •
edited
Loading

Pls check sandbox

@zero88 zero88 mentioned this pull request Feb 22, 2019
Closed
ifindthanh
ifindthanh reviewed Feb 25, 2019
View reviewed changes
sandbox/start.ps1 Outdated Show resolved Hide resolved
ifindthanh
ifindthanh approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@ifindthanh ifindthanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and run containers successfully

@ifindthanh ifindthanh merged commit 55c29e7 into master Feb 26, 2019
@zero88 zero88 deleted the feature/Dockerize branch February 26, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifindthanh ifindthanh ifindthanh approved these changes

@RaiBnod RaiBnod Awaiting requested review from RaiBnod

@cooperbrindle cooperbrindle Awaiting requested review from cooperbrindle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zero88 @ifindthanh