-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New skins for Android #65
Comments
Yeah, it would be great! I'm kind of busy right now, so a PR would be even greater 😃 |
It is not a stopper for me, I just thought that in case somebody would ask it was a good idea to mention the issue in a ticket. |
any news about this? |
@pewh I had no time to tackle this yet. |
It seems that you don't have to change your xml for Android anymore, but can do it directly from Java (https://developers.facebook.com/docs/accountkit/android/customizing). Would be nice to have a single JS interface for applying the theme for both platforms. |
@giladno totally agree about keeping the same JS interface for Android and iOS. |
@gaguirre I wish I could help, but I'm not an Android developer, I can only with with ObjC code :) |
It looks like Facebook added new skin styles: classic, translucent, contemporary.
Because this library uses
compile ('com.facebook.android:account-kit-sdk:4.+')
my app adopted the new skin style as soon as I recompiled.It would be great to add the possibility to pick either skin from the configuration.
Additional Information
The text was updated successfully, but these errors were encountered: