Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New skins for Android #65

Open
fabriziomoscon opened this issue Mar 3, 2017 · 7 comments
Open

New skins for Android #65

fabriziomoscon opened this issue Mar 3, 2017 · 7 comments

Comments

@fabriziomoscon
Copy link

It looks like Facebook added new skin styles: classic, translucent, contemporary.
Because this library uses compile ('com.facebook.android:account-kit-sdk:4.+') my app adopted the new skin style as soon as I recompiled.
It would be great to add the possibility to pick either skin from the configuration.

Additional Information

  • React Native Account Kit version: 0.6.2
  • React Native version: 0.41.2
  • Platform: Android
@gaguirre
Copy link
Collaborator

gaguirre commented Mar 3, 2017

Yeah, it would be great! I'm kind of busy right now, so a PR would be even greater 😃
Otherwise you'll need to wait until next week probably.

@fabriziomoscon
Copy link
Author

fabriziomoscon commented Mar 3, 2017

It is not a stopper for me, I just thought that in case somebody would ask it was a good idea to mention the issue in a ticket.
In case I found some problem with the current code and new skins I will report it.
Cheers

@pewh
Copy link
Contributor

pewh commented Apr 15, 2017

any news about this?

@gaguirre
Copy link
Collaborator

@pewh I had no time to tackle this yet.
Any contribution is welcome ;)

@giladno
Copy link

giladno commented May 5, 2017

It seems that you don't have to change your xml for Android anymore, but can do it directly from Java (https://developers.facebook.com/docs/accountkit/android/customizing). Would be nice to have a single JS interface for applying the theme for both platforms.

@gaguirre
Copy link
Collaborator

gaguirre commented May 5, 2017

@giladno totally agree about keeping the same JS interface for Android and iOS.
I've no time these days to tackle this, maybe in two weeks... any PR is welcome.

@giladno
Copy link

giladno commented May 5, 2017

@gaguirre I wish I could help, but I'm not an Android developer, I can only with with ObjC code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants