Consistency and API simplification: Ditch callbacks and go all-in promises #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@holzmaster ist das getestet und kannst du es unflicten? |
|
Den Konflikt fixe ich nachher. Ist meiner Kenntnis nach noch nicht getestet, wollte ich mit Hans noch machen. |
Heute abend, muss erstmal noch was für die Maloche tun |
|
Hab den aktuellen master reingezogen und Konflikte resolved / Commands portiert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callbacks und Promises sollten nicht gemischt werden, weil man unfangbare Fehler bekommt.
Discord.js ist komplett Promise-basiert, daher sind wir das jetzt auch :harold:
Situation jetzt:
asyncsein (bzw ein Promise returnen)returnzurückgegeben (was vorher über den callback ging)Resolves #107