Fix: keep track of window id

[costowell]

When using toggle() on a terminal spawned using runner(), a new window ID is assigned, but is not tracked, and so an error is thrown for an unknown window ID when attempting to toggle() again.

Found out about this when trying to assign a keybind to toggling a "runner" terminal

map({ "n", "t" }, "<A-r>", function()
  require("nvchad.term").toggle { id = "runner", pos = "float" }
end, { desc = "terminal show runner term" })

Then I used desdic/greyjoy.nvim to spawn a build job into this runner using the following.

nvterm.runner {
  pos = "float",
  cmd = commandstr,
  id = "runner",
  clear_cmd = false
}

With this, I kept getting the aforementioned error.

[siduck]

will test this today

[costowell]

Any progress on this?

[siduck]

yo, sorry i forgot about this.

When using toggle() on a terminal spawned using runner()

both are different functions, how will you use it together?

[costowell]

both are different functions, how will you use it together?

I'm not sure what you mean. Are they not supposed to work together?

[siduck]

both are different functions, how will you use it together?

I'm not sure what you mean. Are they not supposed to work together?

yes

toggle function does this : opens a terminal and runs command only once, now when u call this func again, it'll hide that terminal i.e toggle

Runner () : this will open a terminal and run a command, calling this again will run that command in that opened terminal, if terminal isnt opened then it will open the terminal

[siduck]

you can dm me on discord, tg etc or talk in my discord , tg server, would get quick response than here!

[costowell]

Sorry, I don't have discord, and I'd rather handle this in one spot.

toggle function does this : opens a terminal and runs command only once, now when u call this func again, it'll hide that terminal i.e toggle

As I understand it, toggle() will create a new terminal, otherwise it will just show/hide one that already exists any number of times.

This PR fixes unexpected behavior when using toggle() on a Runner, by keeping track of window IDs better.

[siduck]

when using toggle() on a Runner,

i dont get this part, how toggle on runner?

[costowell]

I left an example in the description of this PR, but the Runner uses the same code to manage the window which is all that really matters with toggling.

[siduck]

hmm so you want a runner() term toggleable by toggle function?

[costowell]

Exactly.

[siduck]

Exactly.

oh i get it now 😁