Get custom 404 page working for all handlers #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2017
|
This now seems to be working, but I'll keep it WIP until I can test it a bit more later. |
SpamNeko
changed the title
|
This seems to be good to go, fixes https://github.com/ewhal/nyaa/issues/135 and https://github.com/ewhal/nyaa/issues/227. |
ibmibmibm
pushed a commit
to ibmibmibm/nyaa
that referenced
this pull request
May 17, 2017
Get custom 404 page working for all handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently wraps functions intended for HandlerFunc and passes off to NotFoundHandler for all 404s, but NotFoundHandler doesn't play nice with gzip.
I'll probably try to make it wrap actual Handlers instead.