Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

Support Simplified Chinese Translation #48

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

aimerneige
Copy link
Contributor

As in title.

Jsut a little work. I did not do build test.

@NyaomiDEV
Copy link
Owner

if you tested it in the test environment then it is safe to merge; if the translation is untested I won't merge it

@aimerneige
Copy link
Contributor Author

Got it. I will do the test.

@aimerneige
Copy link
Contributor Author

I build a deb package and install it on a clean installed ubuntu 22.04 kvm virtual machine. It works fine.

Screenshot from 2022-09-02 22-19-28
Screenshot from 2022-09-02 22-20-06

@NyaomiDEV
Copy link
Owner

there is a test that was not conducted; does sunamu use simplified chinese in a machine or vm which is configured to use simplified chinese? I mean without uncommenting the language in the config file

@aimerneige
Copy link
Contributor Author

I recoverd vm's snapshot and set the languge to Chinese.
Then I install Sunamu, without touching the config file. It display English.

截图 2022-09-03 12-21-44

@aimerneige
Copy link
Contributor Author

When I try to comment the language config, sunamu just write a newline into it.

    language: "en",

@NyaomiDEV
Copy link
Owner

This is not supposed to happen. Can you do language: "" for now?

@aimerneige
Copy link
Contributor Author

This is not supposed to happen. Can you do language: "" for now?

I try this and it works

截图 2022-09-04 01-34-21

@NyaomiDEV NyaomiDEV merged commit 965d341 into NyaomiDEV:master Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants