Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding path level tagging #1509

Closed
wants to merge 1 commit into from
Closed

Adding path level tagging #1509

wants to merge 1 commit into from

Conversation

ymohdriz
Copy link

Hi team,

Currently OAS supports tagging in API and operation level. This PR is to add tagging in path level also.
Related feature request related to this:
#1367

Please review the PR and merge the same.

Thanks,
Mohammed

@darrelmiller
Copy link
Member

Hey @ymohdriz Thanks for the PR. This is definitely an interesting addition that has a low impact on the spec. However, we do have to consider the impact on tooling. We would need to get feedback from folks who are producing documentation based on OpenAPI as to whether they have user requests for these features and whether they are prepared to do the work to incorporate this capability.

Also, this kind of change cannot go into a patch release, it would need to go into a 3.1 branch which I don't believe we have yet created because we are still working on what features will go into 3.1.

We will definitely consider this for inclusion and the more feedback we can get from tooling people on this, the easier it will be to make the call.

@ymohdriz
Copy link
Author

Hi @darrelmiller,

Thanks for the detailed response.
I would like to contribute to this project. But new PRs may turn into new features.
Can you please suggest some areas to work on?

Thanks,
Mohammed

@emreakca
Copy link

emreakca commented Jul 6, 2018

Hey @darrelmiller,

What's the state? Are subtags considered to be a feature, because it would be great!
If it's possible, a push would be very helpful!

@MikeRalphson
Copy link
Member

This PR cannot be accepted as-is, because a) it is targeted at v2.0 of the specification, which is published and will not change, b) it only updates the schema file, which is not the source-of-truth of the specification (the markdown documents are), c) as @darrelmiller says, this change (if accepted) would need to go into a minor release, such as v3.1.0

@emreakca if you need sub-tag grouping / a hierarchy of tags, it would probably be worth commenting on #1367 or #1507 as appropriate.

@MikeRalphson
Copy link
Member

Closing, for the reasons given in #1509 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants