Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some remarks #10

Closed
opiumfive opened this issue Oct 27, 2020 · 8 comments
Closed

some remarks #10

opiumfive opened this issue Oct 27, 2020 · 8 comments

Comments

@opiumfive
Copy link

Hi! Yout lib is very useful, I'd like to use it in production app, but have some suggestions/remarks:

  1. BlazeFace function should have 6 landmarks besides bounding box, but if I try for single openFunc(AndroidConfig.Func.BlazeFace) make faceDetect.landmark2d(), it will crash.
  2. The lib only have arm .so libs, but doesn't have x86 and x86_64, but google play request all architectures
@Crusoekid
Copy link
Collaborator

In response to your question:

  1. You only turn on the BlazeFace function, which is a face detection function. It will definitely crash when you need landmark2. You must openFunc(AndroidConfig.Func.Landmark).
  2. Can you try to put an empty file on the shelf?

@opiumfive
Copy link
Author

Thanks for reply!

image
This is BlazeFace on mediapipe, it returns face bounding box and 6 landmarks and is very fast. I thought these 6 landmarks should be given also, sorry if I'm mistaken.

Does

openFunc(AndroidConfig.Func.BlazeFace).openFunc(AndroidConfig.Func.Landmark)

take more time than

openFunc(AndroidConfig.Func.BlazeFace) ?

  1. Sorry, I didn't understand what you mean. In your lib (aar) there are 2 architectures .so files. The only thing that prevents my production now is what google play doesn't allow releasing with native lib without any missing architecture. I know what x86 and x86_64 is a very little count of devices and ask you at least create documentation\instruction how to build apk with TengineKit and all architectures (even if x86 and x86_64 are empty)

@Crusoekid
Copy link
Collaborator

1, Two functions must take longer than one function, but Tengine-Kit face detection + Landmark can definitely achieve real-time.
2. I provide armeabi and armeabi-v7a to download so, can GooglePlay pass? ?

@opiumfive
Copy link
Author

Thanks for the reply!

  1. No, it needs x86 and x86_64 also

@Crusoekid
Copy link
Collaborator

you can try the newest vesion

@opiumfive
Copy link
Author

opiumfive commented Oct 28, 2020

Thanks!
There are still 2 arm .so libs

image

@Crusoekid
Copy link
Collaborator

no,you try version v1.1.4

@opiumfive
Copy link
Author

Thanks, version v1.1.4 has 4 .so libs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants