Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ID ranges to COB #207

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Adding ID ranges to COB #207

merged 1 commit into from
Jul 28, 2022

Conversation

matentzn
Copy link
Contributor

Is this the way to obtain an ID for COB if you have to make a PR yourself?

@matentzn
Copy link
Contributor Author

cc @wdduncan

Copy link
Member

@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I have no objection.

I don't use idranges in my projects, but I haven't been putting in the work to manage this project, so do whatever you think best.

@matentzn
Copy link
Contributor Author

How do you usually tell people which ids to use?

@jamesaoverton
Copy link
Member

OBI uses a Google Sheet, some projects have a "find next ID script", and other projects have few enough contributors that it's not a big problem. CI tests prevent duplicates.

I recognize the problem that idranges solve, and that it's a working solution, I just think it's kind of ugly. But I haven't been doing the work to manage this project, so I don't want to push any other solution, and I don't want to stand in the way of people doing work.

@matentzn
Copy link
Contributor Author

I think claiming some "next id" in a google sheet is also a great solution, in particular for an ontology like this one where there are ideally only a few classes.. I am happy to switch any time!

@matentzn matentzn merged commit f0ee741 into master Jul 28, 2022
@matentzn matentzn deleted the matentzn-patch-2 branch July 28, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants