Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add exposure of organism class #208

Merged
merged 1 commit into from
Aug 1, 2022
Merged

add exposure of organism class #208

merged 1 commit into from
Aug 1, 2022

Conversation

wdduncan
Copy link
Member

Fixes #192

Added exposure of organism with the definition:

A process during which an organism comes into contact with another entity.

COB doesn't have annotation properties for the creator or creation date. Are we including that metadata?

matentzn
matentzn reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally approve but with, but I am not the right person to do that. :) Thanks for the PR

bpeters42
bpeters42 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@bpeters42 bpeters42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it; this is the minimal consensus across all projects that want exposure terms. Obviously much less to discuss, but this seems to be the safe way to expand COB.

cthoyt
cthoyt reviewed Jul 31, 2022
View reviewed changes
src/ontology/cob-edit.owl

<!-- http://purl.obolibrary.org/obo/COB_0001000 -->

<owl:Class rdf:about="http://purl.obolibrary.org/obo/COB_0001000">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add provenance about the creator and creation time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also it should be possible to add a seeAlso with a link to this PR

@wdduncan
Copy link
Member Author

wdduncan commented Aug 1, 2022 •
edited
Loading

@cthoyt I asked about provenance when I made the PR.

COB doesn't have annotation properties for the creator or creation date. Are we including that metadata?

Given the lack of annotation properties in the OWL, It doesn't look like COB has settled on a policy for provenance. But, I could mistaken.

So, I'm going to merge the PR. If an SOP for provenance is decided upon, I'll add it.

@wdduncan wdduncan closed this Aug 1, 2022
@wdduncan wdduncan reopened this Aug 1, 2022
@wdduncan wdduncan merged commit 5066c5e into master Aug 1, 2022
@wdduncan wdduncan deleted the issue-192 branch August 1, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn left review comments

@cthoyt cthoyt cthoyt left review comments

@bpeters42 bpeters42 bpeters42 approved these changes

@cmungall cmungall Awaiting requested review from cmungall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add exposure of organism class
4 participants
@wdduncan @cthoyt @matentzn @bpeters42