-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ontology for the Anatomy of the Insect SkeletoMuscular system (AISM) #1474
Comments
Discussed on 2021-04-20 call. @matentzn will look at it and reply soon. |
Hey @JCGiron! Aside from the above comments, could you please fill in the following metadata record which will be used by the OBO Foundry website? Note that the values shown are just examples, for example something like aism, cohm, mondo (it does not have to be four letters). your_domain_like_for_example_anatomy could be simply anatomy, and the license should be whatever your actual license is. An example can be found here, but you really only need to fill in the metadata mentioned here. You can copy the below, and make a new comment with the correct information pertaining to your ontology. Thank you!
|
Of course!
|
Thank you @JCGiron before I will review the contents of AISM, would you be able to address the problems on the OBO dashboard: Feel free to contact me on slack if you have problems with this. Ideally this will be all green before we start looking at it in more depth, but at least there should not be any "red" :) Thank you! |
(you can ping me to refresh the dashboard results any time you like!) |
The newly released version (v2021-04-22) has corrected most of the reported issues. |
Thank you @JCGiron Format:
and
Once you have addressed these issues, we will have an anatomy ontology engineer review your modelling, and that should be it! I am pretty confident we get this sorted. All best and find me on slack if you need help! |
Fixed critical problems (see OBOFoundry/OBOFoundry.github.io#1474 (comment)) and created new release.
We revised and fixed the critical problems indicated above. The newly released version (v2021-04-26) incorporated these changes. |
Thank you @JCGiron I can confirm now - all the coherency issues are addressed. We will conduct an anatomy axiom pattern review now to give you some feedback! |
Hi @JCGiron - great to see this work reaching fruition! I remember discussing much of this with Istvan back in 2012. The following is just feedback and does not effect your acceptance into the obo-library: In general I think the patternization makes a lot of sense, especially on the leaf nodes. I particularly like your use of relative position (adjacent_to and continuous_with, encircles) e.g. I love your patterns for sternites and tergites. Places where you might improve:
|
Congratulations, AISM was cleared for inclusion in the OBO Foundry at our OBO Operations Call yesterday. :) Next steps:
Let me know if you need more help! |
Thank you, @matentzn! |
Almost, I fixed it for you here: https://github.com/OBOFoundry/purl.obolibrary.org/pull/760/files |
Thank you, @matentzn! Is there anything else I should do now? |
No, that's it! It will take a while for all the technical issues to permeate through all the system, unless you are in a rush. |
Thanks!, no rush. I was just wondering because of the "submitter action needed" tag still on. We'll wait! |
This issue can be closed now! |
Use this form to register a new ontology with the OBO Foundry. Please read the instructions provided here:
http://obofoundry.org/docs/NewOntologyRegistrationInstructions.html
Ontology title
Ontology for the Anatomy of the Insect SkeletoMuscular system
Requested ID space
AISM
Ontology location
https://github.com/insect-morphology/aism
Contact person
Name: Jennifer Girón
Email address: entiminae@gmail.com
GitHub username: JCGiron
Issue tracker
https://github.com/insect-morphology/aism/issues
Ontology license
Available ontology formats
owl, obo, jason
What domain is the ontology intended to cover?
Insect anatomy
Related OBO Foundry ontologies
CL, PATO, CARO, BSPO, RO, UBERON
Intended use/related projects
Multispecies insect anatomy ontologies are used as bases for robust knowledge bases for specific anatomical terms (Yoder et al. 2010, HAO Portal), improve the accessibility of morphology descriptions (Balhoff et al. 2014), and are useful for improving the modeling of discrete morphological characters in phylogenetic context (Tarasov 2019a, 2019b).
There are two major reasons why insects are poorly represented amongst multispecies anatomy ontologies: lack of a base insect anatomy ontology and the lack of infrastructure to build such resource.
The ontology for the Anatomy of the Insect SkeletoMuscular system contains terms used to describe the cuticle - as a single anatomical structure - and the skeletal muscle system in insect biodiversity research. The cuticle is the product of the single layer epithelium and mirrors changes in the morphology of this single sheet (like a blanket). This ontology serves as a root ontology for other multispecies insect anatomy ontologies.
This ontology repository was created using the Ontology Development Kit.
Data source
Additional comments or remarks
The text was updated successfully, but these errors were encountered: