-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create mcro.md #2368
Create mcro.md #2368
Conversation
One of our automated tests failed: For your contact person, we require a GitHub username in the |
@jamesaoverton that's fine. Thanks! |
It looks like the error in the test is due to a difference in the formatting (observed vs expected). It would be useful to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several parts in the dashboard check that are not passing: https://obofoundry.org/obo-nor.github.io/dashboard/mcro/dashboard.html
what's the policy on accepting ontologies that are not passing parts (besides the plurality of users check)?
The definition of "passing" is to not have any fails, not to have only passes, so MCRO passes. However, @ProfTuan,
|
Indeed, the ontology passes the dashboard. However, a quick manual review shows several problems: for example there are two classes named entity: |
@pfabry @cthoyt - Let's stick with the process.
@ProfTuan I agree though with @cthoyt that your description could be a bit more detailed, given that the main consumers of the registry will not know what a model card report is. Is a rough approximation:
|
@matentzn @cthoyt I provided an update to .md file. However. I want to be sure, is there a description section for the .yml file? I've looked at various .yml files for obo and none of them have a description section. |
It's true, we've had difficulty convincing new ontology requesters to write nice, detailed descriptions of what their ontology does, what was the motivation, etc. in the actual submission markdown, even given the fact that they already had to write it for the submission. Here's an example of a well-written ontology description: https://obofoundry.org/ontology/mondo. In https://raw.githubusercontent.com/OBOFoundry/OBOFoundry.github.io/master/ontology/mondo.md you can clearly see where the detailed description is written. I highly encourage you to start adding the following text, which I have merely copy-pasted from your original issue:
^ all of this text was already written. Please please please edit AND revise it so anyone who looks at the page for your ontology can better understand what it is, why it exists, and why it's part of obo (in a way that's nice english prose, not copy/pasted offhand comments) |
I'll revise it. I should mention that the examples and templates that was shown to me had very simple descriptions which is what I thought was expected. |
@ProfTuan just a quick ping so we can start listing your ontology on our site! |
Remaining action items:@ProfTuan thanks for the edits. This is better, but
|
@ProfTuan thanks for adding more content, please ping me with my github handle when both the open action items above are addressed. Thank you! |
@matentzn both are addressed to the best of my knowledge. |
@ProfTuan Thank you for working on addressing the concerns raised by @cthoyt and @matentzn. Couple of things regarding the metadata provided:
You can refer to https://raw.githubusercontent.com/OBOFoundry/OBOFoundry.github.io/master/ontology/mondo.md or https://raw.githubusercontent.com/OBOFoundry/OBOFoundry.github.io/master/ontology/uberon.md for how these fields are populated. |
@deepakunni3 FYI my concerns are explicitly not yet addressed |
@cthoyt Got it. I have updated my previous comment accordingly |
@matentzn I added what I thought was missing along what @deepakunni3 had mentioned. Let me know if there's any issues. |
I recommend sourcing the original publication my Mitchell et al
https://arxiv.org/abs/1810.03993
…On Fri, Jun 9, 2023 at 9:30 AM Charles Tapley Hoyt ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ontology/mcro.md
<#2368 (comment)>
:
> + title: 'Toward a standard formal semantic representation of the model card report'
+repository: https://github.com/UTHealth-Ontology/MCRO
+tracker: https://github.com/UTHealth-Ontology/MCRO/issues
+usages:
+- description: 'MCRO used for publishing model cards'
+ user: https://github.com/UTHealth-Ontology/MCRO-Software
+ examples:
+ - description: 'Demonstration of Java-based library utilizing MCRO to output RDF-based model card reports'
+ url: https://github.com/UTHealth-Ontology/MCRO-Software
+ publications:
+ - id: https://doi.org/10.1145/3543873.3587601
+ title: 'Application of an ontology for model cards to generate computable artifacts for linking machine learning information from biomedical research'
+activity_status: active
+---
+
+Model card reports are documents detailing transparent metadata information relating to machine learning models. Analogous with drug labels and nutritional labels, the goal of model cards are to communicate relevant information on all aspects of a machine learning model that have undergone any experimentation. The National Institutes of Health, through their Bridge2AI initiative, expressed interest in model cards as an artifact to communicate specifics and promote transparency for AI-based machine learning models in biomedical research. However, these reports are presented in static documents, and have the potential to impede any possible retrieval, analysis, and aggregation of these reports. Model card reports translated as RDF-based formats could help in this effort, including supplementing application tools to analyze AI-based machine learning models.
I now understand that a model card is some kind of metadata about a
machine learning model, but I still don't understand in any detail. Can you
provide a detailed, concrete example of a model card (in the markdown)?
Maybe an image would be helpful.
@ProfTuan <https://github.com/ProfTuan> Do you understand the issue I am
having? I am a person with no knowledge of this topic and I want to
understand it, so I need to be taught in a way that's written to help me
learn. Other people who are reading through OBO Foundry will probably also
feel the same way.
—
Reply to this email directly, view it on GitHub
<#2368 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMOMCWXBA64RXOUCY3XLXKNFT7ANCNFSM6AAAAAAYCRYHHQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
Hi @ProfTuan, I saw you made an update to the PR, but I am not sure if you saw my message at #2368 (comment). Here's what it said:
Can you please comment on this? I think Chris's suggestion is good to include relevant references, but not sufficient to address my concerns. I would appreciate if you could give some feedback, because I'm not sure if you understand what I'm asking or not. |
@cthoyt The paper @cmungall linked contains images of cards and details. Why wouldn't giving the paper as an example reference won't be sufficient? |
@handemcginty I disagree that just linking to a paper is sufficient. Expecting someone to follow a link to read and understand paper is a pretty big burden for someone reading through OBO Foundry who wants to just understand what any given ontology is about. I admit that in many places, the topics are pretty common knowledge and asking for a detailed description wasn't necessary. However, here, this topic is outside of the typical scope. If the paper has nice examples, perhaps we could adapt them directly into the @ProfTuan it would be really important that you can let us know that you have read some of this feedback |
@cthoyt I don't understand what you disagree with. I was asking why you think it is not sufficient to have the paper for this ontology is not sufficient. I see similarly situated ontologies: https://obofoundry.org/ontology/ontoavida.html and https://obofoundry.org/ontology/kisao.html citing references for further information. |
Actually I don't understand what the misunderstanding is, especially since we are referring to a short document (1-2 pages) that describe information about a thing. I did add some updates recently but what more is there to add, short of writing a pedantic description about a simple report? |
I think the description is useful and sufficiently detailed. My only suggestion would be to link to the arXiv paper instead of (or in addition to) the ACM paper, since the ACM paper is not open access and so unreadable by many people. |
added github handle
Fix sort order for dependencies, suggest shorter title.
Removed `prov-o` dependency because it is not an OBO project.
Fix order of keys under `contact`.
…ry.github.io into mcro-inclusion
updated description
updated descriptions of md file
updated bottom description
added extra content to description; added user tag; added url tag.
Resolves #1912