[17.0][MIG] stock analytic: Migration to 17.0 #614

moitabenfdz · 2023-12-21T12:40:12Z

No description provided.

… Stock analytic XML part is now migrated Add logo for generic modules

- migration point, put all the modules to not installable

This module allows the user to generate analytic information from stock moves. - Fixed flake8 and pylint errors.

Remove sale and purchase dependency. Add test Only assign analytic account if account != valuation acc Changing field name account_analytic_id Adjust to OCA latest guidelines. Add some usahe info on README

Remove remaining encoding hints. Correct lint in test Correct flake8 in test Fix documentation and test_flake8

Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-11.0/account-analytic-11.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-stock_analytic/de/

Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt_BR/

Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/ca/

Fixes OCA#257

Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/hr/

Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/de/

Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt/

Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/es/

…voice

(cherry picked from commit 9255622)

aisopuro · 2024-04-16T12:19:56Z

I've been using this code while migrating/developing other things. The one thing I noticed was missing was that the propagation of the analytic distribution does not actually work (I'm not sure if that is a version change or something else). Regardless, I made a fix, which the author is free to cherry-pick into this PR if that makes more sense: #645

Otherwise the tests at least are passing, and I haven't found anything that is in conflict with any version changes.

rousseldenis · 2024-04-17T06:30:14Z

@moitabenfdz Could you cherry-pick the fix proposed by @aisopuro in #645 ?

AndrzejGerasimukARCHIMEDES · 2024-04-28T16:30:03Z

Hi.
I have install this version to my test environment on which I have prepare upgrade from R14 to R17.
I want to report that this module needs pre-migration scripts.
Firstly there is a confilct on a view level. Before upgrade we need to do
delete from ir_ui_view where arch_fs ~ 'stock_analytic';

Second thing: when odoo goes to odoo.models:
Prepare computation of stock.move.line.analytic_distribution
I have a lot of notification such as

odoo.schema: Keep unexpected index stock_move__name_index on table stock_move 
odoo.schema: Keep unexpected index stock_move__priority_index on table stock_move 
odoo.schema: Keep unexpected index stock_move__create_date_index on table stock_move 
odoo.schema: Keep unexpected index stock_picking__priority_index on table stock_picking 
odoo.schema: Keep unexpected index stock_picking__date_index on table stock_picking 
odoo.schema: Keep unexpected index stock_rule__company_id_index on table stock_rule 
odoo.schema: Keep unexpected index stock_rule__auto_index on table stock_rule

And after that I got a warning

py.warnings: /home/odoo/src/odoo/odoo/addons/base/models/ir_module.py:178: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, stock_analytic can just have a UTF8 description with not need for a declaration.
  File "/home/odoo/src/odoo/odoo-bin", line 8, in <module>

And most important: Historical data was lost. There are no premigration script that will migrate data from analytic_account_id and analitytic_tag_ids to analytic_distribution.
Upgrade just add new field and delete old ones, So I have lost whole historical data from stock analytic.

aisopuro · 2024-04-29T08:51:49Z

I believe the warning about the deprecated XML can be fixed by rebasing this branch on top of 17. It is apparently caused by out-of-date tool settings in the repo, that should be updated in the latest 17.

AndrzejGerasimukARCHIMEDES · 2024-04-29T09:30:20Z

@aisopuro thanks for reply. I found reason and how to resolve it

in: stock_analytic/static/description/index.html

We need to delete XML declarations

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">

and add to head section
<meta charset="UTF-8">

Also
In stock_analytic/views/stock_scrap_views.xml
There is a lack of XML declarations at the begining of code
<?xml version="1.0" encoding="UTF-8" ?>

And to be honest i think that in each view the UTF-8 sentence schould by in capital letters

This is my first project on which I collaborate with OCA.
What is the etiquette of good practice? I propose changes in the comments and the authors correct them into the code, or should I commit the proposals myself?

aisopuro · 2024-04-29T09:39:35Z

@AndrzejGerasimukARCHIMEDES it depends. For small additions/improvements you can do as I did earlier in this PR and make a new branch/PR and let the author know they can cherry-pick your change if they think it works.

For this XML thing, it depends on the style guide and the project readme generation configurations (OCA/odoo-pre-commit-hooks#94).

For me personally, my philosophy is "if they didn't make a lint for it, it probably isn't worth caring about, and fixing it will just add noise to the git log". So I wouldn't change the case of XML declarations unless a lint in the project said something about it.

Ultimately its up to the maintainers to weigh in on whether they think its worth it or not.

If you want to have it fixed, then I recommend my approach from earlier in this PR: make a separate branch where you include a separate commit that fixes the case. Then inform the author of this PR that they are free to cherry-pick it in here if they want to.

AndrzejGerasimukARCHIMEDES · 2024-04-29T10:06:26Z

@aisopuro

So I can't create my own branch for cherry-picking

@moitabenfdz can You consider make small changes from #614 (comment)?

(sorry if i do anything wrong in giving a feedback - i am a newbie)

Also it would be great if You add pre-migration script in
stock_analytic/migrations/17.0.0.0.0/pre-migration-cleanup.py

import logging

_logger = logging.getLogger(__name__)


# noinspection PyUnusedLocal
def migrate(cr, installed_version):
    _logger.info(f'Start migration stock_analytic 17.0.0.0.0 from {installed_version} - pre cleanup')

    with cr.savepoint():

        cr.execute(
            """
                delete from ir_ui_view where arch_fs ~ 'stock_analytic'           
        """
        )

    _logger.info('migration stock_analytic finished')

aisopuro · 2024-04-29T11:07:43Z

@AndrzejGerasimukARCHIMEDES you will need to fork the project into some organization you have write access to, either your company's or your personal one. That can then be public, and can be referenced freely.

AndrzejGerasimukARCHIMEDES · 2024-04-29T12:51:30Z

@aisopuro Thanks for help.

@moitabenfdz i have made PR #651
Can You cherry-pick changes from it? (79b498c)

peluko00 · 2024-05-17T13:29:04Z

Any update @moitabenfdz ?

GuillemCForgeFlow

code review LGTM 👍🏿

StefanRijnhart · 2024-07-08T14:28:41Z

@AndrzejGerasimukARCHIMEDES Your migration script from #651 seems to belong primarily in the 16.0 branch, which is where the switch from analytic_account_id to analytic_distribution is made. I agree with @aisopuro that the other changes in your branch are less important and don't need to be included in here in. So I think we can proceed with merging this one first, and then go ahead with any other suggestions in new PRs.

OCA-git-bot · 2024-07-08T14:54:54Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

peluko00

LGTM

peluko00 · 2024-08-06T10:57:21Z

It's ready @StefanRijnhart?

StefanRijnhart · 2024-08-07T05:46:42Z

@peluko00 yes!

/ocabot merge nobump

OCA-git-bot · 2024-08-07T05:46:52Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-614-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot · 2024-08-07T05:51:26Z

Congratulations, your PR was merged at 63dd863. Thanks a lot for contributing to OCA. ❤️

Hanane ELKHAL and others added 30 commits December 21, 2023 13:20

migration to v7

098ae42

merge with mathieu

3306b13

update for migration V7

2be3ced

add images

6bb9de6

update for wilog v7.0

c725d52

Add contract customer invoice and migrate [IMP] SMS erase print [IMP]…

58248fa

… Stock analytic XML part is now migrated Add logo for generic modules

- change the logo of all modules

3dd157b

- migration point, put all the modules to not installable

- Added new module stock_analytic

894d517

This module allows the user to generate analytic information from stock moves. - Fixed flake8 and pylint errors.

Adapt original module according OCA Standard

5f46632

Remove sale and purchase dependency. Add test Only assign analytic account if account != valuation acc Changing field name account_analytic_id Adjust to OCA latest guidelines. Add some usahe info on README

[MIG]stock_analytic to v9

9b07f25

[MIG]stock_analytic to v10

deb3cdf

11.0 MIG stock_analytic

cf00ab4

Add the ability to pick Analytic account on picking form.

5bafae3

Remove remaining encoding hints. Correct lint in test Correct flake8 in test Fix documentation and test_flake8

Translated using Weblate (German)

8f22389

Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-11.0/account-analytic-11.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-stock_analytic/de/

[MIG]stock_analytic to v12

20a5997

[MIG] Updated the tests of the module stock_analytic.

a47c513

Translated using Weblate (Catalan)

2aa857a

Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/ca/

[12.0] [FIX] Wrong runbot link in readme

3d1ecab

[12.0] [FIX] stock_analytic: Analytic account field is in wrong page

01a89fe

Fixes OCA#257

Translated using Weblate (Croatian)

a95b083

Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/hr/

[IMP] stock_analytic: Add analytic account to scrap

1e8c50e

Translated using Weblate (German)

bdd3250

Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/de/

Translated using Weblate (Portuguese)

9609bc1

Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt/

Translated using Weblate (Spanish)

47a1947

Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/es/

[FIX] Apply analytic account on COGS account when booking customer in…

102f32f

…voice

[IMP] stock_analytic: black, isort

1a54a6d

[MIG] stock_analytic: Migration to 13.0

6e456d9

stock_analytic 12.0.1.1.2

b35d6c6

(cherry picked from commit 9255622)

[IMP] stock_analytic: black, isort

fd8a222

This was referenced Apr 16, 2024

[17.0][MIG] mrp_stock_analytic #644

Merged

[17.0][FIX] stock_analytic: actually propagate distribution #645

Closed

[FIX] stock_analytic: actually propagate distribution

fa50c40

GuillemCForgeFlow approved these changes Jun 12, 2024

View reviewed changes

StefanRijnhart approved these changes Jul 8, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 8, 2024

peluko00 reviewed Aug 6, 2024

View reviewed changes

peluko00 mentioned this pull request Aug 6, 2024

[17.0][MIG] stock_picking_analytic: Migration to 17.0 #676

Merged

StefanRijnhart mentioned this pull request Aug 6, 2024

[16.0][IMP] stock_analytic: salvage analytic distribution from procurement #641

Merged

OCA-git-bot added the bot is merging ⏳ label Aug 7, 2024

OCA-git-bot merged commit e930e8d into OCA:17.0 Aug 7, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] stock analytic: Migration to 17.0 #614

[17.0][MIG] stock analytic: Migration to 17.0 #614

moitabenfdz commented Dec 21, 2023

aisopuro commented Apr 16, 2024

rousseldenis commented Apr 17, 2024

AndrzejGerasimukARCHIMEDES commented Apr 28, 2024 •

edited

Loading

aisopuro commented Apr 29, 2024

AndrzejGerasimukARCHIMEDES commented Apr 29, 2024 •

edited

Loading

aisopuro commented Apr 29, 2024

AndrzejGerasimukARCHIMEDES commented Apr 29, 2024

aisopuro commented Apr 29, 2024

AndrzejGerasimukARCHIMEDES commented Apr 29, 2024

peluko00 commented May 17, 2024

GuillemCForgeFlow left a comment

StefanRijnhart commented Jul 8, 2024

OCA-git-bot commented Jul 8, 2024

peluko00 left a comment

peluko00 commented Aug 6, 2024

StefanRijnhart commented Aug 7, 2024

OCA-git-bot commented Aug 7, 2024

OCA-git-bot commented Aug 7, 2024

[17.0][MIG] stock analytic: Migration to 17.0 #614

[17.0][MIG] stock analytic: Migration to 17.0 #614

Conversation

moitabenfdz commented Dec 21, 2023

aisopuro commented Apr 16, 2024

rousseldenis commented Apr 17, 2024

AndrzejGerasimukARCHIMEDES commented Apr 28, 2024 • edited Loading

aisopuro commented Apr 29, 2024

AndrzejGerasimukARCHIMEDES commented Apr 29, 2024 • edited Loading

aisopuro commented Apr 29, 2024

AndrzejGerasimukARCHIMEDES commented Apr 29, 2024

aisopuro commented Apr 29, 2024

AndrzejGerasimukARCHIMEDES commented Apr 29, 2024

peluko00 commented May 17, 2024

GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

StefanRijnhart commented Jul 8, 2024

OCA-git-bot commented Jul 8, 2024

peluko00 left a comment

Choose a reason for hiding this comment

peluko00 commented Aug 6, 2024

StefanRijnhart commented Aug 7, 2024

OCA-git-bot commented Aug 7, 2024

OCA-git-bot commented Aug 7, 2024

AndrzejGerasimukARCHIMEDES commented Apr 28, 2024 •

edited

Loading

AndrzejGerasimukARCHIMEDES commented Apr 29, 2024 •

edited

Loading