Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] account_budget_oca: Migration to 12.0 #22

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

oihane
Copy link
Contributor

@oihane oihane commented May 28, 2019

No description provided.

@nikul-serpentcs
Copy link
Member

@oihane Can you please Fix Comment's as per Old PR.

@oihane
Copy link
Contributor Author

oihane commented May 28, 2019

@nikul-serpentcs I've think I fixed them, take a look, but I think I did not miss anyone.

@oihane oihane force-pushed the 12.0-mig-account_budget branch 2 times, most recently from 046ef9b to c2d8c04 Compare May 28, 2019 10:27
account_budget_oca/models/account_budget.py Outdated Show resolved Hide resolved
account_budget_oca/models/account_budget.py Outdated Show resolved Hide resolved
@oihane oihane force-pushed the 12.0-mig-account_budget branch 2 times, most recently from 056fb79 to 0f5043e Compare May 28, 2019 13:31
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

account_budget_oca/models/account_budget.py Outdated Show resolved Hide resolved
account_budget_oca/models/account_budget.py Outdated Show resolved Hide resolved
account_budget_oca/models/account_budget.py Outdated Show resolved Hide resolved
account_budget_oca/models/account_budget.py Outdated Show resolved Hide resolved
account_budget_oca/models/account_budget.py Outdated Show resolved Hide resolved
account_budget_oca/views/res_config_settings_views.xml Outdated Show resolved Hide resolved
account_budget_oca/views/account_budget_views.xml Outdated Show resolved Hide resolved
@anajuaristi
Copy link

👍 LGTM
We need to have this merged so... please any other review?

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 11, 2019
@pedrobaeza
Copy link
Member

Merging seeing the green status in all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants