-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] account_budget_oca: Migration to 12.0 #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oihane
force-pushed
the
12.0-mig-account_budget
branch
from
May 28, 2019 09:19
ec97499
to
0b7cb7c
Compare
@oihane Can you please Fix Comment's as per Old PR. |
@nikul-serpentcs I've think I fixed them, take a look, but I think I did not miss anyone. |
oihane
force-pushed
the
12.0-mig-account_budget
branch
2 times, most recently
from
May 28, 2019 10:27
046ef9b
to
c2d8c04
Compare
astirpe
suggested changes
May 28, 2019
oihane
force-pushed
the
12.0-mig-account_budget
branch
2 times, most recently
from
May 28, 2019 13:31
056fb79
to
0f5043e
Compare
astirpe
suggested changes
May 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
oihane
force-pushed
the
12.0-mig-account_budget
branch
from
May 29, 2019 14:04
0f5043e
to
6606893
Compare
oihane
force-pushed
the
12.0-mig-account_budget
branch
from
June 4, 2019 14:31
6606893
to
42af671
Compare
👍 LGTM |
Merging seeing the green status in all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.