Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_budget_oca: Migration to version 16.0 #71

Merged
merged 35 commits into from
Sep 27, 2023
Merged

[16.0][MIG] account_budget_oca: Migration to version 16.0 #71

merged 35 commits into from
Sep 27, 2023

Conversation

polqubiq
Copy link

No description provided.

oihane and others added 30 commits September 15, 2023 12:40
@oihane @polqubiq
[MIG] account_budget_oca: Migration to 12.0
651ee7d
@OCA-git-bot @polqubiq
[ADD] icon.png
3cbe3cc
@oihane @polqubiq
[FIX] account_budget_oca: fails automatic merge because duplicated de…
aa6e737 
…finition
@oihane @polqubiq
[FIX] account_budget_oca: duplicated message definition
fe67a39
@oihane @polqubiq
[MIG] account_budget_template: migration to 12.0
a41caf4
@cvinh @polqubiq
[FIX] fix date format in psql query
cef6701
@cvinh @polqubiq
[IMP] cleanup old wizard occurrences
2f6c117
@OCA-git-bot @polqubiq
account_budget_oca 12.0.1.0.1
6facb55
@amcor @polqubiq
[IMP] account_budget_oca: black, isort
7eafbcb
@amcor @polqubiq
[13.0][MIG] account_budget_oca: Migration to 13.0
b7f5b85
@amcor @polqubiq
[IMP] apply suggestions
d2fa5b0
@amcor @polqubiq
[FIX] apply suggestions
c0f3c43
@amcor @polqubiq
[ADD] add migration
34ca497
@amcor @gaikaz @polqubiq
Update account_budget_oca/models/account_budget.py
715593e 
Co-authored-by: Gailius Kazlauskas <17097810+gaikaz@users.noreply.github.com>
@amcor @gaikaz @polqubiq
Update account_budget_oca/models/account_budget.py
e5ac2d2 
Co-authored-by: Gailius Kazlauskas <17097810+gaikaz@users.noreply.github.com>
@Freni-OSI @polqubiq
[14.0][MIG] account_budget_oca
3901511
@oca-travis @polqubiq
[UPD] Update account_budget_oca.pot
2a1fc75
@OCA-git-bot @polqubiq
[UPD] README.rst
353d66e
@Noel000 @polqubiq
Translated using Weblate (Catalan)
c09cad2 
Currently translated at 100.0% (66 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/ca/
@francesco-ooops @polqubiq
Translated using Weblate (Italian)
8dbad34 
Currently translated at 68.1% (45 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/it/
@Saran440 @polqubiq
[FIX] update copier
6eadc34
@Saran440 @polqubiq
[FIX] account_budget_oca: add tagged in test script
29a7da2
@mymage @polqubiq
Translated using Weblate (Italian)
7829cba 
Currently translated at 68.1% (45 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/it/
@sysadminmatmoz @polqubiq
Translated using Weblate (Slovenian)
78e7e8a 
Currently translated at 57.5% (38 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/sl/
@mymage @polqubiq
Translated using Weblate (Italian)
5211ef0 
Currently translated at 68.1% (45 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/it/
@sanrav @polqubiq
Translated using Weblate (French)
106497b 
Currently translated at 69.6% (46 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/fr/
@francesco-ooops @polqubiq
Translated using Weblate (Italian)
7006ff1 
Currently translated at 68.1% (45 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/it/
@sanrav @polqubiq
Added translation using Weblate (French (France) (fr_FR))
a4f0974
@sanrav @polqubiq
Translated using Weblate (French)
24829a1 
Currently translated at 100.0% (66 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/fr/
@sanrav @polqubiq
Translated using Weblate (French (France) (fr_FR))
f5e4814 
Currently translated at 100.0% (66 of 66 strings)

Translation: account-budgeting-14.0/account-budgeting-14.0-account_budget_oca
Translate-URL: https://translation.odoo-community.org/projects/account-budgeting-14-0/account-budgeting-14-0-account_budget_oca/fr_FR/
@polqubiq
Copy link
Author

polqubiq commented Sep 18, 2023 •
edited

You have to talk in this repository in English. The error about the XML-ID account.data_account_type_revenue is because this has changed and now there's not anymore account.account.type model. You should adjust the code to this condition.

Good morning @pedrobaeza I have already completed the migration of the module correctly!

On the other hand, the fact that the account.account.type model does not exist in v16 may need to be added in the migration guide, at least that the user_type_id field was a Many2one related to account.account.type and that now has been replaced by a field called account_type and is a selection field.

Thank you.

@pedrobaeza
Copy link
Member

That is not a framework change, but a datamodel/data one that you should research and apply on migrations.

The migration guide is only for framework changes. If not, there are literally thousand of datamodel changes (see OCA/OpenUpgrade@a060a76), and the guide won't be useful in that case, apart from not always having a replacement one, or it depends on the context. Dumping all of this in a guide is barely impossible, or as said, not practical. It can be debatable though if people want to contribute to a guide of this kind, but apart from the existing one.

@pedrobaeza
Copy link
Member

/ocabot migration account_budget_oca

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 18, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 3, 2022
Open
1 task
@PaolaEras
Copy link

@pedrobaeza after testing functionally the module migrated, I consider it to be working correctly.
The operation has also been compared with v14 and I don't find any errors, it would be interesting to have the module fully operational for v16

@pedrobaeza
Copy link
Member

pedrobaeza commented Sep 20, 2023 •
edited

OK, just approve it using the GitHub flow, and other qualified reviewer should review the PR. You can review other PRs and ask in exchange that they review yours.

@chaojuunzhou
Copy link

Code reviewed and functionally tested

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@polqubiq
Copy link
Author

Good morning @pedrobaeza, is everything okay?

Greetings!

@pedrobaeza
Copy link
Member

Well, none of the reviewers are PSC/maintainers, but let's unlock it. Please increase your activity on OCA, doing more reviews on other PRs apart from yours, and you'll increase your trustability.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-71-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 26, 2023
@OCA-git-bot
Merge PR #71 into 16.0
292a3a7 
Signed-off-by pedrobaeza
@polqubiq
Copy link
Author

@pedrobaeza parece que se iba a mergear el PR, pero no se ha hecho del todo. ¿Sabes qué ha ocurrido?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-71-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ad1f19d into OCA:16.0 Sep 27, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e800a43. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaolaEras PaolaEras PaolaEras approved these changes

@chaojuunzhou chaojuunzhou chaojuunzhou approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet