Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mis_builder: update min/max function signatures #116

Merged
merged 2 commits into from
Sep 8, 2015

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Aug 28, 2015

so min(x, y, ...) and min([x, y, ..]) both work as expected.

so min(x, y, ...) and min([x, y, ..]) both work as expected.
@laetitia-gangloff
Copy link

👍

@@ -81,16 +81,16 @@ def _avg(l):
return sum(l) / float(len(l))


def _min(l):
def _min(*l):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't call it args for being easily recognisable?

@lmignon
Copy link

lmignon commented Aug 31, 2015

👍

1 similar comment
@pedrobaeza
Copy link
Member

👍

@sbidoul
Copy link
Member Author

sbidoul commented Sep 8, 2015

This one is good for merging.

pedrobaeza added a commit that referenced this pull request Sep 8, 2015
[IMP] mis_builder: update min/max function signatures
@pedrobaeza pedrobaeza merged commit 053541f into OCA:8.0 Sep 8, 2015
@sbidoul sbidoul deleted the 8.0-mis_builder-minmax-fix branch September 8, 2015 15:35
rconjour pushed a commit to EssentNovaTeam/account-financial-reporting that referenced this pull request Mar 16, 2020
…-115

8.0 [FIX] Bug OCA#115 on account_auto_fy_sequence: auto-create fiscal-year specific sequence should not have a sequence type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants