Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] account_move_line_search_extension : impossible to post a manual entry #82

Closed
fclementic2c opened this issue Nov 18, 2014 · 8 comments

Comments

@fclementic2c
Copy link
Member

module : account_move_line_search_extension (with filters on top of the tree view 'journal items'

  • select a journal and type in a period
  • click on create
  • input a date, description, debit... and press enter
    -> the new line generate is considered a new move so it is impossible to create the couterpart entry of the first move

I noticed a second issue : After you select the journal and period and click on create, the journal field on the move line is not automatically field in + the 2 columns journal and period are not automatically hidden as in standard.

@fclementic2c
Copy link
Member Author

@luc-demeyer Hi luc, I just notice a problem with this module that I report here. If you have some time to check it out

@luc-demeyer
Copy link
Contributor

Frédéric,

The purpose of this module is easy consultation (drill down), not the (rather unusable) ‘fast encoding’ mechanism which is provided via the standard ‘Journal Items’ menu entry.

What I propose in order to fix the issue reported by you is to disable the creation of new entries from the ‘Journal Items Search All’ list view.

Do you agree with this or do you have other suggestions ?

Tx,

Luc

http://www.noviat.com/ www.noviat.com

Rusatiralaan 1, 1083 Brussel

+32 2 808 86 38

From: Frédéric Clementi [mailto:notifications@github.com]
Sent: dinsdag 18 november 2014 17:09
To: OCA/account-financial-tools
Cc: luc-demeyer
Subject: Re: [account-financial-tools] [7.0] account_move_line_search_extension : impossible to post a manual entry (#82)

@luc-demeyer https://github.com/luc-demeyer Hi luc, I just notice a problem with this module that I report here. If you have some time to check it out


Reply to this email directly or view it on GitHub #82 (comment) . https://github.com/notifications/beacon/AHWZQV_3ONEPYERQYaME_m9kQDOv5X25ks5nO2afgaJpZM4C9L6N.gif

@pedrobaeza
Copy link
Member

I also agree with the solution. This must be readonly.

@fclementic2c
Copy link
Member Author

Now I understand why you did not want to merge both menus 'journal items' and 'journal items search all'... but now both menus are merged :(78205e0)

Ok we will propose a PR to revert this but as you say, we also need to hide this create button if possible.

Functionnaly, we absolutely need to post entries from 'journal items' because it is much faster than creating move from 'journal entries' (ie : automatic VAT) when it comes to post petty cash or the corporate credit card expenses for ex.

@pedrobaeza
Copy link
Member

But what I don't understand is that if you can fast-encoding journal entries with the other menu, why you cannot do it in this new menu. Same mechanisms can be provided on both.

@luc-demeyer
Copy link
Contributor

@pedrobaeza the so-called "fast" encoding uses the period selected in the standard 'Journal Items' menu whereas the 'search all' allows partial period names (e.g. to search on all items in periods with 2014 in the name). Merging both approaches will be confusing for the end user, hence my proposal to keep the two menu items and block creation of journal items when using the 'search all'.

@pedrobaeza
Copy link
Member

@luc-demeyer Understood

Let's keep both menus and we should add this clarifications on module description to avoid this debate occurs again in the future. Don't you think?

@StefanRijnhart
Copy link
Member

Closing as proposed workaround was merged.

hbrunn pushed a commit to hbrunn/account-financial-tools that referenced this issue May 28, 2021
…OCA#82)

* [ADD] Merge into sale-financial of migrated account_invoice_open_sale

* [FIX] add modult to travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants