[15.0][MIG] account_invoice_constraint_chronology #1360

Shide · 2022-03-22T15:19:12Z

Straight forward migration.

Added return on the @api.onchange method to pass pre-commit
Changed SavepointCase to TransactionCase on tests

Please review @yajo @rafaelbn @HaraldPanten 😄

oca-clabot · 2022-03-22T15:19:15Z

Hey @Shide, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Adrien Peiffer adrien.peiffer@etspeiffer.be (no github login found)

Appreciation of efforts,
OCA CLAbot

Shide · 2022-03-22T15:41:36Z

Seems like installing vatnumber is failing (for version 1.2 and 1.1) due to base_vat_optional_vies dependency

Installing vatnumber with pip on my machine discards v1.2 and v1.1, falling onto v1.0

pip install vatnumber
Collecting vatnumber
  Downloading vatnumber-1.2.tar.gz (19 kB)
    ERROR: Command errored out with exit status 1:
     command: /home/eduardo/anaconda3/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-vrk6z_42/vatnumber_dfc1096ac71340a296dbdd18671ee685/setup.py'"'"'; __file__='"'"'/tmp/pip-install-vrk6z_42/vatnumber_dfc1096ac71340a296dbdd18671ee685/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-b3bnk0xg
         cwd: /tmp/pip-install-vrk6z_42/vatnumber_dfc1096ac71340a296dbdd18671ee685/
    Complete output (1 lines):
    error in vatnumber setup command: use_2to3 is invalid.
    ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/d7/7c/869b59cd9cb6ed1057372cb704a3b86688ae8c12cfc7fcaedbc1424f5e7f/vatnumber-1.2.tar.gz#sha256=4e9e9cabcff6076d8deb8a347edfd5d0ab8cab1ed344fdbe5dd4a6110a2f2c7b (from https://pypi.org/simple/vatnumber/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
  Downloading vatnumber-1.1.tar.gz (22 kB)
    ERROR: Command errored out with exit status 1:
     command: /home/eduardo/anaconda3/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-vrk6z_42/vatnumber_a71c44053b364b6da662b29160aa60a4/setup.py'"'"'; __file__='"'"'/tmp/pip-install-vrk6z_42/vatnumber_a71c44053b364b6da662b29160aa60a4/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-vdrrcew8
         cwd: /tmp/pip-install-vrk6z_42/vatnumber_a71c44053b364b6da662b29160aa60a4/
    Complete output (1 lines):
    error in vatnumber setup command: use_2to3 is invalid.
    ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/1f/77/18485f3f4bdcec93004a3eac639565eb21e4a556b9d16a5687b735a02498/vatnumber-1.1.tar.gz#sha256=ff7017420e137609a74ce0dbe6ba16c86ea5317d50ca398f8f423141c07fae18 (from https://pypi.org/simple/vatnumber/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
  Downloading vatnumber-1.0.tar.gz (21 kB)
Building wheels for collected packages: vatnumber
  Building wheel for vatnumber (setup.py) ... done
  Created wheel for vatnumber: filename=vatnumber-1.0-py3-none-any.whl size=20265 sha256=8e8684a96810443f653c00a2ba21aa8b9ac624548e682c859d0ee83c21802669
  Stored in directory: /home/eduardo/.cache/pip/wheels/4d/27/32/6d4e8da4f5a851bf0486a9dcc4ea3dc11fee12f9502eaba950
Successfully built vatnumber
Installing collected packages: vatnumber
Successfully installed vatnumber-1.0

Same error than runboat trying to install vatnumber from pip, but in my case, pip fallbacks well.

rafaelbn · 2022-03-22T19:33:10Z

@sbidoul please could you take a quick look on #1360 (comment) about PIP and vatnumber

Thank you!

sbidoul · 2022-03-22T19:44:34Z

vatnumber is unmaintained and does not install with the last setuptools. Odoo does not use it anymore, we must find a replacement too.

Shide · 2022-03-23T12:35:45Z

@sbidoul Any chances to allow pip to fallaback to older versions on Runboat?
This will unlock migrations not related directly or indirectly to modules that has external dependencies such vatnumber.

sbidoul · 2022-03-23T13:06:43Z

@Shide actually setuptools is already constrained for older Odoo branches for that same reason. Since for these, it is an Odoo dependency which we can't change, there is no other solution.

Here,
1/ we have control on the use of that unmaintained dependency, so we can replace it
2/ actually I don't even see where it is imported in this repo: base_vat_optional_vies declares the dependency but does not seem to use it, so maybe it's simply a migration oversight
3/ I'm not keen to pin setuptools for more recent Odoo versions because it will certainly create problems down the line if there are dependencies that themselves require a recent setuptools

rafaelbn · 2022-03-23T23:39:51Z

/ocabot migration account_invoice_constraint_chronology

This dependency is giving problems elsewhere and is not really used directly by this module. See OCA#1360 (comment) @moduon MT-455

yajo · 2022-03-28T08:39:11Z

I pushed the fix for the vatnumber problem. Let's see now. Regarding the PR itself, it looks good to me.

rafaelbn · 2022-03-30T14:39:55Z

/ocabot rebase

OCA-git-bot · 2022-03-30T14:40:20Z

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-1360:15.0-mig-account_invoice_constraint_chronology failed with output:

remote: Permission to moduon/account-financial-tools.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/account-financial-tools/': The requested URL returned error: 403

rafaelbn

Functional 👍

…t.py

…ice_constraint_chronology [IMP] DEFAULT_SERVER_DATE_FORMAT [IMP] display formatted date with context timezone in exception popup for account_invoice_constraint_chronology addons [ADD] Add context in tests for account_invoice_constraint_chronology addons [IMP] Use exceptions.warning for account_invoice_constraint_chronology addons [IMP] Remove exclamation mark [ADD] Add .pot file for account_invoice_constraint_chronology [IMP] Use .env for account_invoice_constraint_chronology tests [IMP] Use onchange decorator, add white space at end of file, correct ypo mistake for account_invoice_constraint_chronology [IMP] Improve performance

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

It was not used in these tests anyway.

Addresses the issue as commented here: - OCA#1206 - OCA#1152 (comment) Summary of the steps to reproduce the problem: 1. Set on the invoices journal the constraint chronology. 2. Validate an invoice for this journal today. 3. Your accountant says there's an error on an invoice from yesterday. 4. Cancel it an set it to draft. You don't even need to modify anything 5. Try to post the invoice. 6. You'll get a chronology error. In v12 this was considered but it was lost on the migration to v13: https://github.com/OCA/account-financial-tools/blob/800c02474e5aa43cee592e93499d2a480be46d32/account_invoice_constraint_chronology/model/account_invoice.py#L50 https://github.com/OCA/account-financial-tools/blob/800c02474e5aa43cee592e93499d2a480be46d32/account_invoice_constraint_chronology/model/account_invoice.py#L70-L73 TT34624

This dependency is giving problems elsewhere and is not really used directly by this module. See OCA#1360 (comment) @moduon MT-455

yajo · 2022-03-31T07:42:48Z

Rebased, to see if that fixes the build.

yajo · 2022-03-31T09:14:50Z

Please @Shide review test failures.

Shide · 2022-03-31T15:29:46Z

Please @Shide review test failures.

Done, thanks! :)

OCA-git-bot · 2022-03-31T16:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rafaelbn · 2022-03-31T18:23:07Z

/ocabot merge patch

OCA-git-bot · 2022-03-31T18:23:35Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1360-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot · 2022-03-31T18:29:37Z

Congratulations, your PR was merged at 857dd4e. Thanks a lot for contributing to OCA. ❤️

This dependency is giving problems elsewhere and is not really used directly by this module. See OCA#1360 (comment) @moduon MT-455

This dependency is giving problems elsewhere and is not really used directly by this module. See OCA/account-financial-tools#1360 (comment) @moduon MT-455

Shide changed the title ~~[15.0][MIG] account_invoice_constraint_chronology~~ [15.0][MIG] WIP account_invoice_constraint_chronology Mar 22, 2022

Shide force-pushed the 15.0-mig-account_invoice_constraint_chronology branch from 0d42d9d to b847bef Compare March 22, 2022 15:31

Shide changed the title ~~[15.0][MIG] WIP account_invoice_constraint_chronology~~ [15.0][MIG] account_invoice_constraint_chronology Mar 22, 2022

rafaelbn requested a review from yajo March 23, 2022 23:39

OCA-git-bot added this to the 15.0 milestone Mar 23, 2022

OCA-git-bot mentioned this pull request Mar 23, 2022

Migration to version 15.0 #1253

Open

31 tasks

rafaelbn mentioned this pull request Mar 24, 2022

[15.0][MIG] account_menu: migrate module from 14.0 to 15.0 #1275

Merged

yajo approved these changes Mar 28, 2022

View reviewed changes

rafaelbn added the needs review label Mar 30, 2022

rafaelbn approved these changes Mar 30, 2022

View reviewed changes

OCA-git-bot added the approved label Mar 30, 2022

yajo mentioned this pull request Mar 31, 2022

[15.0][MIG] account_chart_update #1346

Merged

Adrien Peiffer and others added 7 commits March 31, 2022 07:42

[ADD] Add account_invoice_constraint_chronology

6fed704

[IMP] Use new API on account_invoice_constraint_chronology for accoun…

6e0bd49

…t.py

[IMP] account_inv/account_invoice_constraint_chronology doc spelling

68c38c0

Add license key in __openerp__.py

51b705c

Add OCA as author of OCA addons

46fa9db

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

[FIX] common.DB does not exist anymore in stable 8.0

4c3cb5b

It was not used in these tests anyway.

OCA-git-bot and others added 11 commits March 31, 2022 07:42

account_invoice_constraint_chronology 12.0.1.0.2

593d33f

[IMP] account_invoice_constraint_chronology: black, isort, prettier

04ddac9

[MIG] account_invoice_constraint_chronology: Migration to 13.0

18d5dd1

[IMP] account_invoice_constraint_chronology: black, isort, prettier

96e09eb

[MIG] account_invoice_constraint_chronology: Migration to 14.0

df01829

wip

d6386bb

[UPD] README.rst

dfdb325

[IMP] account_invoice_constraint_chronology: black, isort, prettier

54acde4

[MIG] account_invoice_constraint_chronology: Migration to 15.0

91dab9c

[FIX] base_vat_optional_vies: remove unneeded vatnumber

7a467d7

This dependency is giving problems elsewhere and is not really used directly by this module. See OCA#1360 (comment) @moduon MT-455

yajo force-pushed the 15.0-mig-account_invoice_constraint_chronology branch from 7df0b27 to 7a467d7 Compare March 31, 2022 07:42

[FIX] Add journal_id when creating account move reversal on tests

8ea2ed4

OCA-git-bot added the ready to merge label Mar 31, 2022

OCA-git-bot added the bot is merging ⏳ label Mar 31, 2022

OCA-git-bot merged commit 3dd61fc into OCA:15.0 Mar 31, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 31, 2022

yajo deleted the 15.0-mig-account_invoice_constraint_chronology branch April 1, 2022 07:41

sbidoul mentioned this pull request May 2, 2022

[15.0] [MIG] account_move_line_tax_editable #1368

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] account_invoice_constraint_chronology #1360

[15.0][MIG] account_invoice_constraint_chronology #1360

Shide commented Mar 22, 2022 •

edited

Loading

oca-clabot commented Mar 22, 2022

Shide commented Mar 22, 2022

rafaelbn commented Mar 22, 2022

sbidoul commented Mar 22, 2022

Shide commented Mar 23, 2022

sbidoul commented Mar 23, 2022

rafaelbn commented Mar 23, 2022

yajo commented Mar 28, 2022

rafaelbn commented Mar 30, 2022

OCA-git-bot commented Mar 30, 2022

rafaelbn left a comment

yajo commented Mar 31, 2022

yajo commented Mar 31, 2022

Shide commented Mar 31, 2022

OCA-git-bot commented Mar 31, 2022

rafaelbn commented Mar 31, 2022

OCA-git-bot commented Mar 31, 2022

OCA-git-bot commented Mar 31, 2022

[15.0][MIG] account_invoice_constraint_chronology #1360

[15.0][MIG] account_invoice_constraint_chronology #1360

Conversation

Shide commented Mar 22, 2022 • edited Loading

oca-clabot commented Mar 22, 2022

Shide commented Mar 22, 2022

rafaelbn commented Mar 22, 2022

sbidoul commented Mar 22, 2022

Shide commented Mar 23, 2022

sbidoul commented Mar 23, 2022

rafaelbn commented Mar 23, 2022

yajo commented Mar 28, 2022

rafaelbn commented Mar 30, 2022

OCA-git-bot commented Mar 30, 2022

rafaelbn left a comment

Choose a reason for hiding this comment

yajo commented Mar 31, 2022

yajo commented Mar 31, 2022

Shide commented Mar 31, 2022

OCA-git-bot commented Mar 31, 2022

rafaelbn commented Mar 31, 2022

OCA-git-bot commented Mar 31, 2022

OCA-git-bot commented Mar 31, 2022

Shide commented Mar 22, 2022 •

edited

Loading