Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] account_move_name_sequence: call flush before to post the moves #1514

Merged

Conversation

fernandahf
Copy link
Contributor

Description of the issue/feature this PR addresses:

Module

account_move_name_sequence

Describe the bug

When creating a credit note on a supplier bill, the following validation error is raised :

A move can not be posted with name "/" or empty value
Check the journal sequence, please

To Reproduce

Affected versions: 14.0, 15.0

Steps to reproduce the behavior:

  1. Create a vendor bill and post it
  2. Click on the Add credit note
  3. Select "Full refund" or "Full refund and new draft invoice" on the wizard then click on Revers

Fix #1501

Current behavior before PR:

An error is raised at the time of the creation of a credit note on the supplier bill.

Desired behavior after PR is merged:

Supplier bills should be properly reversed.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@OCA-git-bot
Copy link
Contributor

Hi @moylop260, @alexis-via, @frahikLV,
some modules you are maintaining are being modified, check this out!

@fernandahf fernandahf changed the title [FIX] account_move_name_sequence: call flush before to post the moves [14.0][FIX] account_move_name_sequence: call flush before to post the moves Nov 30, 2022
Copy link
Contributor

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fernandahf I have just tested it and issue is fixed from my point of view !

@moylop260
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1514-by-moylop260-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9e92168 into OCA:14.0 Dec 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b50bc9d. Thanks a lot for contributing to OCA. ❤️

RodrigoBM added a commit to factorlibre/account-financial-tools that referenced this pull request Dec 2, 2022
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
RodrigoBM added a commit to factorlibre/account-financial-tools that referenced this pull request Dec 2, 2022
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
RodrigoBM added a commit to factorlibre/account-financial-tools that referenced this pull request Dec 2, 2022
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
RodrigoBM added a commit to factorlibre/account-financial-tools that referenced this pull request Dec 8, 2022
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
andreagidaltig pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request Sep 30, 2023
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
andreagidaltig pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request Oct 9, 2023
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
andreagidaltig pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request Oct 9, 2023
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
moitabenfdz pushed a commit to DynAppsNV/account-financial-tools that referenced this pull request Nov 13, 2023
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
keylor2906 pushed a commit to vauxoo-dev/account-financial-tools that referenced this pull request Dec 5, 2023
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
keylor2906 pushed a commit to Vauxoo/account-financial-tools that referenced this pull request Dec 5, 2023
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
cormaza pushed a commit to cormaza/account-financial-reporting that referenced this pull request Jun 2, 2024
BertVGroenendael pushed a commit to DynAppsNV/account-financial-tools that referenced this pull request Oct 16, 2024
…supplier_reference method

same issue OCA#1501
this fix not working for v16 OCA#1514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[14.0, 15.0] account_move_name_sequence error with credit note on supplier bill
4 participants