Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] 9.0 account invoice shipping address #135

Closed
wants to merge 8 commits into from
Closed

[PORT] 9.0 account invoice shipping address #135

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2016

This modules adds shipping address to invoice.

@@ -23,9 +23,9 @@

{
"name": "Invoice Shipping Address",
'summary': """
'description': """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put description. The description is in the README.rst file. This is only summary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just summary key?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Odoo v8, the description is automatically binded from the README.rst file, so no need to duplicate it.

@pedrobaeza
Copy link
Member

Thanks for the PR. I have seen that there's a very similar module on https://github.com/OCA/account-invoice-reporting/tree/9.0/account_invoice_delivery_address.

Can you tell me which one is better?

@pedrobaeza pedrobaeza mentioned this pull request Mar 7, 2016
26 tasks
@ghost
Copy link
Author

ghost commented Mar 7, 2016

I think the module you mentioned is more complete than this. It controls the delivery address and also provides an RML report. What do you think of moving those to this PR and replacing it with QWeb report?

@pedrobaeza
Copy link
Member

Yeah, that seems a better option.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 24, 2021
@github-actions github-actions bot closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants