9.0 [ADD] account_invoice_check_total #162

ThomasBinsfeld · 2016-07-12T09:49:28Z

No description provided.

ThomasBinsfeld · 2016-07-12T09:49:51Z

sbidoul · 2016-07-12T09:52:54Z

account_invoice_check_total/README.rst

+===========
+
+Bugs are tracked on `GitHub Issues
+<https://github.com/OCA/{project_repo}/issues>`_. In case of trouble, please


replace {project_repo}

sbidoul · 2016-07-12T13:18:16Z

@ThomasBinsfeld runbot is red because existing tests do set the check_total field when creating invoices.

Perhaps we should make check_total required on the supplier invoice/refund form and have the check trigger only if check_total is set.

What do you think?

sbidoul · 2016-07-13T10:00:40Z

@ThomasBinsfeld it seems this is not finished, you need to

declare the group like this https://github.com/odoo/odoo/blob/965024902db880af005a9688a277b28e076a4a7e/addons/account/security/account_security.xml#L29
link the field to the group in the view

sbidoul · 2016-07-15T07:39:45Z

account_invoice_check_total/security/account_invoice_security.xml

+<data noupdate="0">
+
+    <record id="group_supplier_inv_check_total" model="res.groups">
+        <field name="name">Check Total on supplier bills</field>


Check Total on Vendor Bills

sbidoul · 2016-07-15T07:40:20Z

@ThomasBinsfeld one last small remark. It now works fine.

👍 (code review and functional test on runbot)

adrienpeiffer · 2016-09-05T07:45:52Z

@ThomasBinsfeld I just add group_supplier_inv_check_total on account.config.settings. So, it's now possible to add this group for all users in one click.

atchuthan

few minor corrections

Runbot test 👍

atchuthan · 2016-09-30T13:28:31Z

account_invoice_check_total/README.rst

+
+Add a Verification Total field on vendor bills.
+The user enters the taxes included invoice total as printed on the vendor bill, then enters the invoice lines and taxes. The system then checks the total computed by Odoo is the same as the verification total.
+


Add runbot link in Usage section
Use template from maintainers repo (https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst)

atchuthan · 2016-09-30T13:29:00Z

account_invoice_check_total/__openerp__.py

+        'security/account_invoice_security.xml',
+        'views/account_invoice.xml',
+    ],
+    'demo': [


Remove empty keys

atchuthan · 2016-09-30T13:29:36Z

account_invoice_check_total/security/account_invoice_security.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>


use odoo instead of openerp for 9.0

atchuthan · 2016-09-30T13:30:15Z

account_invoice_check_total/security/account_invoice_security.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+<data noupdate="0">


make it as noupdate="1" or remove the tag itself

atchuthan · 2016-09-30T13:31:25Z

account_invoice_check_total/views/account_config_settings.xml

+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
+
+<openerp>
+<data>


replace openerp and data with odoo xml tag

Cedric-Pigeon · 2016-10-11T07:07:50Z

👍 code review

pedrobaeza · 2016-10-11T07:17:10Z

account_invoice_check_total/models/account_invoice.py

+    @api.multi
+    def action_move_create(self):
+        for inv in self:
+            gr = 'account_invoice_check_total.group_supplier_inv_check_total'


You can import the group from the other file to have only one reference

pedrobaeza · 2016-10-11T07:17:59Z

account_invoice_check_total/models/account_invoice.py

+    @api.model
+    def _prepare_refund(self, invoice, date_invoice=None,
+                        date=None, description=None, journal_id=None):
+        vals = super(AccountInvoice, self)._prepare_refund(invoice,


Use this for shorten the number of lines:

vals = super(AccountInvoice, self)._prepare_refund( invoice, date_invoice, date, description, journal_id)

pedrobaeza · 2016-10-11T07:18:29Z

account_invoice_check_total/models/account_invoice.py

+                                                           description,
+                                                           journal_id)
+
+        if invoice and invoice.type in ['in_invoice', 'in_refund']:


No need to check previously if invoice. Only second condition is needed.

pedrobaeza · 2016-10-11T07:18:56Z

account_invoice_check_total/static/description/icon.svg

@@ -0,0 +1,79 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>


Put the PNG icon, not the SVG (unless it's an specific one)

pedrobaeza · 2016-10-11T07:19:15Z

account_invoice_check_total/tests/test_account_invoice.py

+        self.account_invoice_line = self.env['account.invoice.line']
+        self.current_user = self.env.user
+        # Add current user to group: group_supplier_inv_check_total
+        group_id = 'account_invoice_check_total.group_supplier_inv_check_total'


Import the group variable

pedrobaeza · 2016-10-11T08:03:36Z

Please attend last comments and squash all the commits together by author, and I'll merge

pedrobaeza · 2016-10-11T08:39:00Z

account_invoice_check_total/tests/test_account_invoice.py

@@ -4,6 +4,8 @@

 from openerp.tests.common import TransactionCase
 from openerp.exceptions import UserError
+from openerp.addons.account_invoice_check_total.models.account_invoice\


Use from ..models.account_invoice import GROUP_AICT

pedrobaeza · 2016-10-11T08:40:00Z

account_invoice_check_total/models/account_config_settings.py

+
+from openerp import fields, models
+
+GROUP_XML_ID = 'account_invoice_check_total.group_supplier_inv_check_total'


Import here also the group

pedrobaeza · 2016-10-11T08:42:15Z

Please remember to squash commits

ThomasBinsfeld · 2016-10-11T08:51:39Z

@pedrobaeza Thanks for the review. I squashed cosmetic commits to preserve a meaningful history.

pedrobaeza · 2016-10-11T09:20:43Z

Please use relative import as requested, or the linter fails.

pedrobaeza · 2016-10-11T09:21:18Z

I see still a lot of irrelevant commits at the beginning. Please squash them.

adrienpeiffer · 2016-10-11T13:25:27Z

@pedrobaeza this one is now ok for you ?

pedrobaeza · 2016-10-11T13:38:31Z

Yeah, this is better, thanks.

sbidoul reviewed Jul 12, 2016
View reviewed changes

sbidoul reviewed Jul 15, 2016
View reviewed changes

sbidoul added the needs review label Jul 15, 2016

atchuthan approved these changes Sep 30, 2016

View reviewed changes

sbidoul mentioned this pull request Oct 10, 2016

Migration of account_invoice_supplier_ref_unique to 9.0 #161

Merged

pedrobaeza requested changes Oct 11, 2016

View reviewed changes

ThomasBinsfeld force-pushed the 9.0-add_account_invoice_check_total branch from fe88110 to 332c4dd Compare October 11, 2016 08:50

ThomasBinsfeld and others added 8 commits October 11, 2016 11:41

[ADD] account_invoice_check_total

7753e7a

[FIX] check_total required, check if set

495f8eb

[FIX] Default value for check_total

a1f9fa2

[FIX] Restore group check

e182d0e

[ADD] group_supplier_inv_check_total

dcd425c

[IMP] Unit tests

f57f09b

[FIX] Rename security group

97cdf85

[ADD] setup.py

8d72c1b

ThomasBinsfeld and others added 4 commits October 11, 2016 11:41

[FIX] check_total: no copy

554e299

[IMP] Add group_supplier_inv_check_total on account.config.settings

9c7d474

[FIX] Use transient model !

f5948b0

[FIX] PEP8, code lisibility, cosmetics

3229b65

ThomasBinsfeld force-pushed the 9.0-add_account_invoice_check_total branch from 332c4dd to 3229b65 Compare October 11, 2016 09:45

pedrobaeza merged commit 962ad26 into OCA:9.0 Oct 11, 2016

pedrobaeza mentioned this pull request Oct 11, 2016

Migration to version 9.0 #109

Closed

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

9.0 [ADD] account_invoice_check_total #162

9.0 [ADD] account_invoice_check_total #162

ThomasBinsfeld commented Jul 12, 2016

ThomasBinsfeld commented Jul 12, 2016

sbidoul Jul 12, 2016

sbidoul commented Jul 12, 2016

sbidoul commented Jul 13, 2016

sbidoul Jul 15, 2016

sbidoul commented Jul 15, 2016

adrienpeiffer commented Sep 5, 2016

atchuthan left a comment

atchuthan Sep 30, 2016

atchuthan Sep 30, 2016

atchuthan Sep 30, 2016

atchuthan Sep 30, 2016

atchuthan Sep 30, 2016

Cedric-Pigeon commented Oct 11, 2016

pedrobaeza Oct 11, 2016

pedrobaeza Oct 11, 2016

pedrobaeza Oct 11, 2016

pedrobaeza Oct 11, 2016

pedrobaeza Oct 11, 2016

pedrobaeza commented Oct 11, 2016

pedrobaeza Oct 11, 2016

pedrobaeza Oct 11, 2016

pedrobaeza commented Oct 11, 2016

ThomasBinsfeld commented Oct 11, 2016

pedrobaeza commented Oct 11, 2016

pedrobaeza commented Oct 11, 2016

adrienpeiffer commented Oct 11, 2016

pedrobaeza commented Oct 11, 2016


		Add a Verification Total field on vendor bills.
		The user enters the taxes included invoice total as printed on the vendor bill, then enters the invoice lines and taxes. The system then checks the total computed by Odoo is the same as the verification total.

		@@ -0,0 +1,11 @@
		<?xml version="1.0" encoding="utf-8"?>
		<openerp>

		@@ -0,0 +1,79 @@
		<?xml version="1.0" encoding="UTF-8" standalone="no"?>


		from openerp import fields, models

		GROUP_XML_ID = 'account_invoice_check_total.group_supplier_inv_check_total'

9.0 [ADD] account_invoice_check_total #162

9.0 [ADD] account_invoice_check_total #162

Conversation

ThomasBinsfeld commented Jul 12, 2016

ThomasBinsfeld commented Jul 12, 2016

Choose a reason for hiding this comment

sbidoul commented Jul 12, 2016

sbidoul commented Jul 13, 2016

Choose a reason for hiding this comment

sbidoul commented Jul 15, 2016

adrienpeiffer commented Sep 5, 2016

atchuthan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cedric-Pigeon commented Oct 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 11, 2016

ThomasBinsfeld commented Oct 11, 2016

pedrobaeza commented Oct 11, 2016

pedrobaeza commented Oct 11, 2016

adrienpeiffer commented Oct 11, 2016

pedrobaeza commented Oct 11, 2016