-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][9.0] account_invoice_merge_purchase module #233
[MIG][9.0] account_invoice_merge_purchase module #233
Conversation
b601824
to
c0ef224
Compare
|
||
|
||
Usage | ||
===== | ||
|
||
Select several vendor bills from the same partner and click on **Merge Partner | ||
Invoice** in Action button menu. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current runbot contains this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality is ok. However I'd suggest to pop a warning whenever the responsible differ across invoices in the same way it does with other not compatible merging parameters (different partner, paid o open bill...).
@chienandalu That's out of the scope of this module |
@pedrobaeza The problem is that when the bill responsible differs, those bills are not going to merge but the user has no clue about the reason why the merging didn't success. So the user is going to have to review manually every not merged bill and find out. |
This module is only a glue module that adds purchase fields to the merge process. What you are mentioning is something for the main module, account_invoice_merge. That's why I say this is out of scope of this PR. Anyway, previous screen before merging informs about the criteria to merge invoices. You should fill an issue with the improvement you are mentioning (which is good, that's out of question), but for being done in the module account_invoice_merge. |
Absolutely right, @pedrobaeza 😄 I missed the point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionality 👍
Syncing from upstream OCA/account-invoicing (12.0)
cc @Tecnativa