Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][9.0] account_invoice_merge_purchase module #233

Merged
merged 3 commits into from
Mar 23, 2017

Conversation

cubells
Copy link
Member

@cubells cubells commented Mar 6, 2017

  • Updated README
  • Updated tests

cc @Tecnativa

@cubells cubells force-pushed the 9.0-mig-account_invoice_merge_purchase branch from b601824 to c0ef224 Compare March 6, 2017 19:20


Usage
=====

Select several vendor bills from the same partner and click on **Merge Partner
Invoice** in Action button menu.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I don't see this option:
2017-03-07_18-01-08

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current runbot contains this.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is ok. However I'd suggest to pop a warning whenever the responsible differ across invoices in the same way it does with other not compatible merging parameters (different partner, paid o open bill...).

@pedrobaeza
Copy link
Member

@chienandalu That's out of the scope of this module

@chienandalu
Copy link
Member

@pedrobaeza The problem is that when the bill responsible differs, those bills are not going to merge but the user has no clue about the reason why the merging didn't success. So the user is going to have to review manually every not merged bill and find out.

@pedrobaeza
Copy link
Member

pedrobaeza commented Mar 23, 2017

This module is only a glue module that adds purchase fields to the merge process. What you are mentioning is something for the main module, account_invoice_merge. That's why I say this is out of scope of this PR. Anyway, previous screen before merging informs about the criteria to merge invoices. You should fill an issue with the improvement you are mentioning (which is good, that's out of question), but for being done in the module account_invoice_merge.

@chienandalu
Copy link
Member

Absolutely right, @pedrobaeza 😄 I missed the point

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality 👍

@pedrobaeza pedrobaeza merged commit 3574a7a into OCA:9.0 Mar 23, 2017
@pedrobaeza pedrobaeza deleted the 9.0-mig-account_invoice_merge_purchase branch March 23, 2017 10:10
@pedrobaeza pedrobaeza mentioned this pull request Mar 23, 2017
26 tasks
BT-dherreros pushed a commit to BT-dherreros/account-invoicing that referenced this pull request Apr 29, 2019
Syncing from upstream OCA/account-invoicing (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants