-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][MIGR] account_invoice_force_number #242
[10.0][MIGR] account_invoice_force_number #242
Conversation
cd70f2a
to
820e5bf
Compare
9309e2a
to
e565848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tafaRU thanks, just a remark
Force Invoice Number | ||
==================== | ||
|
||
This module allows to force the invoice numbering. It displays the internal_number field. If user fills that field, the typed value will be used as invoice (and move) number. Otherwise, the next sequence number will be retrieved and saved. So, the new field has to be used when user doesn't want to use the default invoice numbering for a specific invoice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal_number
-> move_name
eb3f7a3
to
16bff2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
@eLBati, what about errors on https://travis-ci.org/OCA/account-invoicing/jobs/219682034? |
@tafaRU uhm I don't know, they need to be checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis check
@eLBati, I just tried to restart that build was red and now, I don't know why, it appears as green! |
@tafaRU thanks, I would squash some commits |
…and apply OCA guidelines
16bff2f
to
d1e1e52
Compare
@eLBati, I squashed commits a bit! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
I have tried it and it works |
Runbot not working, rebuild and still not able to log in. |
d1e1e52
to
1e03a70
Compare
@lreficent, amended last commit to trigger all builds, please try again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical and functional review, LGTM 👍
This PR is still WIP according to its label.