Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][MIGR] account_invoice_force_number #242

Merged
merged 5 commits into from
May 15, 2017

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Mar 27, 2017

This PR is still WIP according to its label.

@tafaRU tafaRU force-pushed the 10.0-mig-account_invoice_force_number branch from cd70f2a to 820e5bf Compare March 27, 2017 12:23
@tafaRU tafaRU force-pushed the 10.0-mig-account_invoice_force_number branch 4 times, most recently from 9309e2a to e565848 Compare March 28, 2017 08:53
@pedrobaeza pedrobaeza mentioned this pull request Apr 4, 2017
34 tasks
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tafaRU thanks, just a remark

Force Invoice Number
====================

This module allows to force the invoice numbering. It displays the internal_number field. If user fills that field, the typed value will be used as invoice (and move) number. Otherwise, the next sequence number will be retrieved and saved. So, the new field has to be used when user doesn't want to use the default invoice numbering for a specific invoice.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal_number -> move_name

@tafaRU tafaRU force-pushed the 10.0-mig-account_invoice_force_number branch from eb3f7a3 to 16bff2f Compare April 7, 2017 13:22
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@tafaRU
Copy link
Member Author

tafaRU commented Apr 7, 2017

@eLBati, what about errors on https://travis-ci.org/OCA/account-invoicing/jobs/219682034?
Do you think they are related?

@eLBati
Copy link
Member

eLBati commented Apr 7, 2017

@tafaRU uhm I don't know, they need to be checked

Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis check

@tafaRU
Copy link
Member Author

tafaRU commented May 2, 2017

@eLBati, I just tried to restart that build was red and now, I don't know why, it appears as green!

@eLBati
Copy link
Member

eLBati commented May 2, 2017

@tafaRU thanks, I would squash some commits

@tafaRU tafaRU force-pushed the 10.0-mig-account_invoice_force_number branch from 16bff2f to d1e1e52 Compare May 2, 2017 12:28
@tafaRU
Copy link
Member Author

tafaRU commented May 2, 2017

@eLBati, I squashed commits a bit!

Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@stevech091
Copy link

I have tried it and it works

@LoisRForgeFlow
Copy link
Contributor

Runbot not working, rebuild and still not able to log in.

@tafaRU tafaRU force-pushed the 10.0-mig-account_invoice_force_number branch from d1e1e52 to 1e03a70 Compare May 12, 2017 15:30
@tafaRU
Copy link
Member Author

tafaRU commented May 12, 2017

@lreficent, amended last commit to trigger all builds, please try again!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical and functional review, LGTM 👍

@eLBati eLBati merged commit aed1bfb into OCA:10.0 May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants