[10.0][MIG] : account_invoice_customer_ref_unique #257

misern2 · 2017-04-14T14:39:59Z

USAGE

This module adds a insensitive constraint on the name Customer Reference
(name field): (partner_id, name) must be unique.

* Test coverage added * Spanish translation

Travis Build Test

flake errors

flake modifications

AaronHForgeFlow

👍
It'll be great a pre-install hook to prevent this constraint to be triggered when installing.

moylop260 · 2017-09-26T16:14:52Z

account_invoice_customer_ref_unique/models/account_invoice.py

-            invoice = self.browse(cr, uid, i_id, context=context)
+    @api.multi
+    @api.constrains('name')
+    def _check_unique_name_insensitive(self):


In order to increase the performance is faster use a sql constraint based on computed fields with store=True

check the following example where is 4x faster than a python constraint using too many invoices https://github.com/Vauxoo/addons-vauxoo/blob/8.0/supplier_invoice_number_unique/model/account_invoice.py

misern2 · 2017-09-30T09:51:03Z

@moylop260 Thanks for your revision. I pushed a new commit with the SQL Constraints

moylop260 · 2017-09-30T12:47:50Z

account_invoice_customer_ref_unique/models/account_invoice.py

+                invoice.customer_ref_strip = invoice.name.lower()
+    _sql_constraints = [
+        ('unique_customer_ref_strip', 'UNIQUE('
+         'customer_ref_strip, company_id, partner_id)',


s/partner_id/commercial_partner_id/g` in order to supports the case where other address is used for the same partner

moylop260

LGTM just small changes.

And check our beta message of the lint build:
https://travis-ci.org/OCA/account-invoicing/jobs/281607391#L743

************* Module account_invoice_customer_ref_unique
account_invoice_customer_ref_unique/README.rst:32: [E7901(rst-syntax-error), ]  Unexpected possible title overline or transition.|Treating it as ordinary text because it's so short.
account_invoice_customer_ref_unique/README.rst:1: [W7908(missing-newline-extrafiles), ]  Missing newline
************* Module account_invoice_customer_ref_unique.__manifest__
account_invoice_customer_ref_unique/__manifest__.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
account_invoice_customer_ref_unique/__manifest__.py:23: [C8103(manifest-deprecated-key), ] Deprecated key "description" in manifest file
************* Module account_invoice_customer_ref_unique.models.account_invoice
account_invoice_customer_ref_unique/models/account_invoice.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`

moylop260 · 2017-09-30T12:48:03Z

.travis.yml

@@ -1,7 +1,7 @@
 language: python

 python:
-  - "2.7"
+  - "2.7"   


remove this small change

moylop260 · 2017-09-30T12:50:34Z

...and create a hook to auto-fix all current wrong info breaking the constraint:
https://travis-ci.org/OCA/account-invoicing/jobs/281607395#L1407

[FIX] minor travis build issues [FIX] Test updated : Integrity Error

misern2 · 2017-09-30T19:52:16Z

@moylop260 I think it's all finshed. I also checked the travis log file and now there is not any error beta message.
Thanks.

moylop260

Sorry I didn't see this before...

Thanks for your great work!

moylop260 · 2017-09-30T21:20:43Z

account_invoice_customer_ref_unique/__init__.py

@@ -20,4 +20,5 @@
 #
 ##############################################################################

-from . import account_invoice
+
+from . import models


Missing newline

moylop260 · 2017-09-30T21:21:17Z

account_invoice_customer_ref_unique/__init__.py

@@ -20,4 +20,5 @@
 #
 ##############################################################################


Use shortest license like as template module:
https://github.com/OCA/maintainer-tools/blob/master/template/module/models/model_name.py#L2

moylop260 · 2017-09-30T21:22:30Z

account_invoice_customer_ref_unique/README.rst

+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+To contribute to this module, please visit https://odoo-community.org.


missing newline

moylop260 · 2017-09-30T21:23:22Z

account_invoice_customer_ref_unique/README.rst

+
+Configuration
+=============
+


Remove unused sections

moylop260 · 2017-09-30T21:23:43Z

account_invoice_customer_ref_unique/models/account_invoice.py

@@ -0,0 +1,46 @@
+# -*- coding: utf-8 -*-
+# #############################################################################


Short license

houssine78 · 2017-10-02T16:46:37Z

account_invoice_customer_ref_unique/models/account_invoice.py

+    def _compute_customer_ref_strip(self):
+        for invoice in self:
+            invoice_type = invoice.type
+            if invoice_type not in ['out_invoice', 'out_refund']:


maybe we can remove the previous line as the invoice_type variable is only used once in the if statement

shorter license updated Removed unused sections in README removed invoice_type variable in account_invoice.py

misern2 · 2017-10-02T19:03:34Z

Changes requested.
The travis build on my branch was Ok and It fails on this PR in my last commit. Am I missing something ?

pedrobaeza · 2017-10-03T06:12:28Z

Travis is red

github-actions · 2022-03-27T12:13:38Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

misern2 added 5 commits April 14, 2017 13:20

[MIG] v10 migration

ce56fb2

* Test coverage added * Spanish translation

Travis build test

3a8fa28

Travis Build Test

flake errors

b34391c

flake errors

Falke modifications

dfca53f

flake modifications

Readme.rst modifications

96ced7c

misern2 changed the title ~~[10.0][MIG] : account_invoice_customer_ref_uniqe~~ [10.0][MIG] : account_invoice_customer_ref_unique Apr 14, 2017

AaronHForgeFlow mentioned this pull request Sep 26, 2017

Migration to version 10.0 #194

Closed

34 tasks

AaronHForgeFlow approved these changes Sep 26, 2017

View reviewed changes

moylop260 requested changes Sep 26, 2017

View reviewed changes

moylop260 reviewed Sep 30, 2017

View reviewed changes

moylop260 requested changes Sep 30, 2017

View reviewed changes

.travis.yml Outdated

@@ -1,7 +1,7 @@

language: python

python:

- "2.7"

- "2.7"

Copy link

Contributor

moylop260 Sep 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this small change

misern2 force-pushed the 10-invoice_customer_ref_unique branch from 4861ca5 to 32b506a Compare September 30, 2017 18:00

[FIX] comercial_partner_id constraint

aa66b51

[FIX] minor travis build issues [FIX] Test updated : Integrity Error

misern2 force-pushed the 10-invoice_customer_ref_unique branch from 32b506a to aa66b51 Compare September 30, 2017 18:54

moylop260 requested changes Sep 30, 2017

View reviewed changes

adrienpeiffer added this to the 10.0 milestone Oct 2, 2017

houssine78 reviewed Oct 2, 2017

View reviewed changes

Reviews Fixes

2616e8d

shorter license updated Removed unused sections in README removed invoice_type variable in account_invoice.py

houssine78 approved these changes Oct 2, 2017

View reviewed changes

Test fixed

ac7c79e

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 27, 2022

github-actions bot closed this May 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0][MIG] : account_invoice_customer_ref_unique #257

[10.0][MIG] : account_invoice_customer_ref_unique #257

misern2 commented Apr 14, 2017

AaronHForgeFlow left a comment •

edited

Loading

moylop260 Sep 26, 2017

moylop260 Sep 26, 2017

misern2 commented Sep 30, 2017

moylop260 Sep 30, 2017

moylop260 left a comment

moylop260 Sep 30, 2017

moylop260 commented Sep 30, 2017

misern2 commented Sep 30, 2017

moylop260 left a comment

moylop260 Sep 30, 2017

moylop260 Sep 30, 2017

moylop260 Sep 30, 2017

moylop260 Sep 30, 2017

moylop260 Sep 30, 2017

houssine78 Oct 2, 2017

misern2 commented Oct 2, 2017

pedrobaeza commented Oct 3, 2017

github-actions bot commented Mar 27, 2022

		@@ -20,4 +20,5 @@
		#
		##############################################################################

		@@ -0,0 +1,46 @@
		# -- coding: utf-8 --
		# #############################################################################


		Configuration
		=============

[10.0][MIG] : account_invoice_customer_ref_unique #257

[10.0][MIG] : account_invoice_customer_ref_unique #257

Conversation

misern2 commented Apr 14, 2017

USAGE

AaronHForgeFlow left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

misern2 commented Sep 30, 2017

Choose a reason for hiding this comment

moylop260 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moylop260 commented Sep 30, 2017

misern2 commented Sep 30, 2017

moylop260 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

misern2 commented Oct 2, 2017

pedrobaeza commented Oct 3, 2017

github-actions bot commented Mar 27, 2022

AaronHForgeFlow left a comment •

edited

Loading