Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][MIG] sale_timesheet_invoice_description #300

Merged
merged 2 commits into from
Aug 8, 2017
Merged

[10.0][MIG] sale_timesheet_invoice_description #300

merged 2 commits into from
Aug 8, 2017

Conversation

pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza commented Aug 4, 2017 •
edited

  • Standard migration
  • Improved tests

cc @Tecnativa

@pedrobaeza pedrobaeza force-pushed the 10.0-sale_timesheet_invoice_description branch from 502b530 to 8c4c2be Compare August 4, 2017 18:37
@pedrobaeza pedrobaeza mentioned this pull request Aug 4, 2017
Closed
34 tasks
@pedrobaeza
Copy link
Member Author

@carlosdauden @chienandalu please review

chienandalu
chienandalu suggested changes Aug 7, 2017
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok.
Just some tweaks on the README.rst:

  • Bump version on runbot link.

Improve description with something of the sort of:

  1. Go to Timesheets -> Activities and add one with the previous sale order name
    as project.
  2. Set the activity with as many hours as ordered before.

luismontalba
luismontalba approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot

@pedrobaeza pedrobaeza merged commit 94588ff into OCA:10.0 Aug 8, 2017
@pedrobaeza pedrobaeza deleted the 10.0-sale_timesheet_invoice_description branch August 8, 2017 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu requested changes

@luismontalba luismontalba luismontalba approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pedrobaeza @chienandalu @luismontalba @carlosdauden @oca-transbot