[11.0][MIG] account_invoice_refund_link: Migration to 11.0 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhancements: * Reverse link from invoice to refunds also available. * Link at invoice line level, not only at invoice level. * When installing the module after some refunds have been made, the module tries to find the link to the original invoice for them. * OCA Guidelines compliance. * Compatibility in OpenUpgrade for migrating from 8.0 module account_refund_original. * Tests with 100% coverage. Technical changes: * Rename field origin_invoices_ids to origin_invoice_ids * Rename field refund_invoices_description to refund_reason * Rename addon to account_invoice_refund_link
oihane
force-pushed
the
11-mig-account_invoice_refund_link
branch
from
889b9de
to
dbc2e9c
Compare
Odoo already includes a method for preparing the refund, so using it we don't have to make any guess about the returned domain and the method also serves for refunds created directly by code. Initial line match has also been improved comparing product or description.
OCA Transbot updated translations from Transifex
oihane
force-pushed
the
11-mig-account_invoice_refund_link
branch
from
dbc2e9c
to
85dbbaa
Compare
|
Revisión funcional y técnica 👍 |
DarioLodeiros
approved these changes
Nov 13, 2017
misern2
approved these changes
Nov 13, 2017
|
This is required for OCA/l10n-spain#696 can anyone check it? |
|
I'm removing last commit because it introduces some undesired changes:
|
* [FIX] account_invoice_refund_link: Don't copy m2m fields Many2many fields have copy=True property by default, having an incorrect duplication of origin or refund invoices. Steps to reproduce: * Create an invoice * Refund it * Duplicate the original invoice * The refund will be link to 2 original invoices Included tests covering the use cases for avoiding future regressions.
pedrobaeza
force-pushed
the
11-mig-account_invoice_refund_link
branch
from
e71d732
to
41fb014
Compare
pedrobaeza
force-pushed
the
11-mig-account_invoice_refund_link
branch
from
41fb014
to
d15a9bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.