-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] account_invoice_blocking #331
Conversation
[ADD] account_invoice_blocking
@pedrobaeza can I ask you the label "Needs review" for this PR? |
Done |
type_receivable = self.env.ref('account.data_account_type_receivable') | ||
type_payable = self.env.ref('account.data_account_type_payable') | ||
user_type_id_list = [type_receivable.id, type_payable.id] | ||
return self.env['account.move.line'].search([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astirpe Can we check also that the move account is equal to the invoice account, we have advance invoices where we also have a payable/receivable on the invoice line, so i want to trace that one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feketemihai I'm quite busy this period, I'm afraid I will not able to look at it during the next weeks. If you already have implemented a working solution, please open a PR to this branch and I will merge it asap. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for the vendor invoices.
Thanks to you all for the reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (only technical review)
@feketemihai can we merge it? |
I would say it's time to merge anyway ... |
Merging as no answer. |
Thanks! |
Porting of module account_invoice_blocking to V11