Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] account_invoice_blocking #331

Merged
merged 4 commits into from
Sep 17, 2018
Merged

[11.0][MIG] account_invoice_blocking #331

merged 4 commits into from
Sep 17, 2018

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Nov 21, 2017

Porting of module account_invoice_blocking to V11

@pedrobaeza pedrobaeza mentioned this pull request Nov 21, 2017
36 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Nov 21, 2017
@astirpe
Copy link
Member Author

astirpe commented Nov 25, 2017

@pedrobaeza can I ask you the label "Needs review" for this PR?

@pedrobaeza
Copy link
Member

Done

type_receivable = self.env.ref('account.data_account_type_receivable')
type_payable = self.env.ref('account.data_account_type_payable')
user_type_id_list = [type_receivable.id, type_payable.id]
return self.env['account.move.line'].search([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe Can we check also that the move account is equal to the invoice account, we have advance invoices where we also have a payable/receivable on the invoice line, so i want to trace that one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feketemihai I'm quite busy this period, I'm afraid I will not able to look at it during the next weeks. If you already have implemented a working solution, please open a PR to this branch and I will merge it asap. Thank you!

Copy link

@yung-wang yung-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for the vendor invoices.

@astirpe
Copy link
Member Author

astirpe commented Sep 14, 2018

Thanks to you all for the reviews!
My initial intention with this PR was the pure porting of the module. There are some requests for extra functionalities that I don't have time to develop at this moment.
Is it OK to merge this porting as it is, and later on open other PRs for the extra improvements?
I would like to close this old PR, thanks.

Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (only technical review)

@tafaRU
Copy link
Member

tafaRU commented Sep 14, 2018

@feketemihai can we merge it?

@astirpe
Copy link
Member Author

astirpe commented Sep 17, 2018

I would say it's time to merge anyway ...

@tafaRU
Copy link
Member

tafaRU commented Sep 17, 2018

Merging as no answer.

@tafaRU tafaRU merged commit 1dbe376 into OCA:11.0 Sep 17, 2018
@astirpe astirpe deleted the 11_mig_account_invoice_blocking branch September 17, 2018 15:31
@astirpe
Copy link
Member Author

astirpe commented Sep 17, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants