-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] account_invoice_triple_discount #370
[11.0][MIG] account_invoice_triple_discount #370
Conversation
I still see only 1 commit, without the commit history. |
5931a16
to
dfcc1b5
Compare
I think it's correct now (finally). |
Yeah, great! |
@xavierjimenez Travis is red. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about this module. Is this module a tool to make multiple discounts easier?
Because e.g. price 100 * 0.75 = 25 = 100 * 0.5 * 0.5
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/95/10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the version number to 11.0?
<field name="arch" type="xml"> | ||
<xpath expr="//field[@name='invoice_line_ids']//tree//field[@name='discount']" | ||
position="after"> | ||
<field name="discount2" groups="base.group_no_one"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it only for the debug group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same group as the discount field defined in the account_invoicing module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your last 3 commits before merging.
a0fe103
to
599cab9
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Migration of account_invoice_triple_discount module to version 11.0