Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] account_invoice_triple_discount #370

Merged
merged 4 commits into from
Apr 10, 2018

Conversation

xavierjimenez
Copy link
Contributor

Migration of account_invoice_triple_discount module to version 11.0

@pedrobaeza
Copy link
Member

I still see only 1 commit, without the commit history.

@xavierjimenez xavierjimenez force-pushed the 11.0-mig-account_invoice_triple_discount branch from 5931a16 to dfcc1b5 Compare April 4, 2018 15:34
@xavierjimenez
Copy link
Contributor Author

I think it's correct now (finally).

@pedrobaeza
Copy link
Member

Yeah, great!

@pedrobaeza pedrobaeza added this to the 11.0 milestone Apr 4, 2018
@pedrobaeza pedrobaeza mentioned this pull request Apr 4, 2018
36 tasks
@misern2
Copy link

misern2 commented Apr 5, 2018

@xavierjimenez Travis is red.

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about this module. Is this module a tool to make multiple discounts easier?
Because e.g. price 100 * 0.75 = 25 = 100 * 0.5 * 0.5


.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/95/10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the version number to 11.0?

<field name="arch" type="xml">
<xpath expr="//field[@name='invoice_line_ids']//tree//field[@name='discount']"
position="after">
<field name="discount2" groups="base.group_no_one"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it only for the debug group?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same group as the discount field defined in the account_invoicing module.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your last 3 commits before merging.

@xavierjimenez xavierjimenez force-pushed the 11.0-mig-account_invoice_triple_discount branch from a0fe103 to 599cab9 Compare April 10, 2018 10:09
@xavierjimenez
Copy link
Contributor Author

Done!

Copy link

@misern2 misern2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza pedrobaeza merged commit bcbde27 into OCA:11.0 Apr 10, 2018
@xavierjimenez xavierjimenez deleted the 11.0-mig-account_invoice_triple_discount branch April 11, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants