Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11.0 mig account invoice pricelist #390

Merged
merged 8 commits into from
Sep 21, 2018
Merged

11.0 mig account invoice pricelist #390

merged 8 commits into from
Sep 21, 2018

Conversation

amcor
Copy link
Member

@amcor amcor commented Jun 12, 2018 •
edited
Loading

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jun 12, 2018
@amcor amcor mentioned this pull request Jun 12, 2018
Closed
36 tasks
astirpe
astirpe suggested changes Jun 12, 2018
View reviewed changes
account_invoice_pricelist/views/account_invoice_view.xml Outdated
</record>

<record id="view_account_invoice_supplier_form" model="ir.ui.view">
<field name="model">account.invoice</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the indentation

account_invoice_pricelist/demo/res_groups.yml Outdated
@@ -0,0 +1,29 @@
# -*- encoding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the encoding line and use the shorten header

account_invoice_pricelist/README.rst Outdated
Installation
============

Nothing special.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this useless paragraph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Installation paragraph

Copy link
Contributor

@legalsylvain legalsylvain Jun 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe : not required, as it will be overwritten.

account_invoice_pricelist/README.rst Outdated
@@ -0,0 +1,62 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer the png image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even better, use the README by fragments for letting the bot to generate this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use png

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe : same here, not required, as it will be overwritten.

account_invoice_pricelist/models/account_invoice.py Outdated
@@ -0,0 +1,66 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from openerp import models, fields, api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from odoo

account_invoice_pricelist/tests/test_account_invoice_pricelist.py Outdated
@@ -0,0 +1,83 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from openerp.tests.common import SavepointCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from odoo

MeetKD
MeetKD suggested changes Jun 13, 2018
View reviewed changes
account_invoice_pricelist/__manifest__.py Outdated
'Therp BV,'
'Tecnativa,'
'Odoo Community Association (OCA)',
'website': 'http://www.grap.coop',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

website should be https://github.com/OCA/account-invoicing

astirpe
astirpe suggested changes Jun 13, 2018
View reviewed changes
account_invoice_pricelist/README.rst Outdated
@@ -1,62 +1,82 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can keep the original README.rst file as it was already done. No need to replace it.
As far as I understood during this code sprint, the readme will be overwritten automatically by a bot during the night, after this PR is merged. It means that in the meanwhile the original README.rst is still needed.

oihane
oihane reviewed Jun 13, 2018
View reviewed changes
account_invoice_pricelist/README.rst Outdated
For further information, please visit:

* https://www.odoo.com/forum/help-1
**Table of contents**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing travis pylint fail

account_invoice_pricelist/README.rst:34: [E7901(rst-syntax-error), ]  Bullet list ends without a blank line; unexpected unindent.

astirpe
astirpe approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only

@BT-fgarbely
Copy link

Hello @amcor

What is the state on this pull request?
Can you solve the errors in the checks?

Regards,

@amcor
Copy link
Member Author

amcor commented Sep 5, 2018

Runbot is running again.
There are some minors problems with the codecov but i thinks that they arent relevant.

@BT-fgarbely
Copy link

Hello @pedrobaeza

What do you think? Can this PR be merged or not?

Regards

@BT-fgarbely
Copy link

hi, what's the state here?
when will this be merged?

@pedrobaeza pedrobaeza force-pushed the 11.0-mig-account_invoice_pricelist branch 2 times, most recently from 0af2b91 to c2c2903 Compare September 21, 2018 09:20
@pedrobaeza pedrobaeza force-pushed the 11.0-mig-account_invoice_pricelist branch from c2c2903 to 7df4b55 Compare September 21, 2018 09:22
@pedrobaeza pedrobaeza merged commit 06da9ef into OCA:11.0 Sep 21, 2018
@amcor amcor deleted the 11.0-mig-account_invoice_pricelist branch September 21, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oihane oihane oihane left review comments

@legalsylvain legalsylvain legalsylvain left review comments

@MeetKD MeetKD MeetKD requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@astirpe astirpe astirpe approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.