Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] account_voucher_killer #254

Closed
wants to merge 20 commits into from
Closed

[12.0][MIG] account_voucher_killer #254

wants to merge 20 commits into from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented May 22, 2019

anthony-muschang and others added 18 commits May 22, 2019 08:49
@anthony-muschang @astirpe
[CHG] rename "invoicing_voucher_killer" to "account_voucher_killer"
03606e4
@anthony-muschang @astirpe
[CHG] account_voucher_killer: add voucher related menus to group "inv…
8d79631 
…oice_voucher_user"
@anthony-muschang @astirpe
[CHG] account_voucher_killer: description & hide menu "Sales Receipts…
952ccb2 
… Analysis"
@sbidoul @astirpe
[IMP] readme README.md to rst and add credits
fbaef14
@yvaucher @astirpe
Add license key in __openerp__.py
34291c5
@gurneyalex @astirpe
Add OCA as author of OCA addons
c9b53ee 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@phschmidt @astirpe
Add requested descriptions in an OCA README.rst file
38cf6a0
@yvaucher @astirpe
Add missing default oca icons
03185be
@sbidoul @astirpe
[UPD] prefix versions with 8.0
32d443b
@pedrobaeza @astirpe
[MIG] Make modules uninstallable
c18b1ee
@oca-transbot @astirpe
OCA Transbot updated translations from Transifex
9d6757c
@pedrobaeza @astirpe
[IMP] Remove unused POT files
44cd7f2
@sbidoul @astirpe
[FIX] remove en.po that was erroneously created by transbot
033cd59
@pedrobaeza @astirpe
[MIG] Rename manifest files
8122865
@ovnicraft @astirpe
[10.0][MIG] payment killer migration (#480)
4528c41
@oca-travis @astirpe
[UPD] Update account_voucher_killer.pot
434fa3e
@astirpe
[11.0][MIG] account_voucher_killer
28cbf1e
@astirpe
[12.0][MIG] account_voucher_killer
c01d1d8
This was referenced May 22, 2019
Closed
Closed
ThomasBinsfeld
ThomasBinsfeld approved these changes May 22, 2019
View reviewed changes
account_voucher_killer/view/invoice_view.xml
<field name="model">account.invoice</field>
<field name="inherit_id" ref="account.invoice_form" />
<field name="arch" type="xml">
<xpath expr="//button[@name='%(account.action_account_invoice_payment)d']"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking:

Suggested change
<xpath expr="//button[@name='%(account.action_account_invoice_payment)d']"
<button name="%(account.action_account_invoice_payment)d"

(same for two other xpath's)

@pedrobaeza pedrobaeza added this to the 12.0 milestone May 22, 2019
@emagdalenaC2i emagdalenaC2i mentioned this pull request Jun 1, 2019
Closed
16 tasks
@Saran440
Copy link
Member

Function test 👍

@astirpe
Copy link
Member Author

astirpe commented Jun 28, 2019

Thanks @Saran440 could you please go to "Files changed" -> "Review changes" and then "Approve" ?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-254-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 29, 2019
@OCA-git-bot
Merge PR #254 into 12.0
7ee3f8f 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7ee3f8f. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@astirpe astirpe deleted the 12_mig_account_voucher_killer branch July 2, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 approved these changes

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.