Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] [MIG] account_early_payment_discount #370

Closed
wants to merge 7 commits into from
Closed

[13.0] [MIG] account_early_payment_discount #370

wants to merge 7 commits into from

Conversation

phuctranfxvn
Copy link

No description provided.

This was referenced Nov 9, 2020
Closed
Closed
simahawk
simahawk approved these changes Sep 16, 2021
View reviewed changes
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls squash fixup! commits

@grindtildeath
Copy link
Contributor

As this module doesn't do anything on itself, shouldn't it be merged with OCA/account-reconcile#356 ?

@dreispt
Copy link
Member

dreispt commented Dec 4, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 4, 2021
@OCA-git-bot
Merge PR #370 into 13.0
65d97ca 
Signed-off-by dreispt
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 10, 2022
@github-actions github-actions bot closed this May 15, 2022
@dreispt dreispt reopened this May 25, 2022
@dreispt
Copy link
Member

dreispt commented May 25, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 25, 2022
@OCA-git-bot
Merge PR #370 into 13.0
e9561ea 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 29, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 2, 2022
@dreispt
Copy link
Member

dreispt commented Oct 2, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 2, 2022
@OCA-git-bot
Merge PR #370 into 13.0
a0ebf8b 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

rafaelbn
rafaelbn approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafaelbn
Copy link
Member

rafaelbn commented Oct 8, 2022

Hello @simahawk , could you check this and merge it? 😄

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 9, 2022
@dreispt
Copy link
Member

dreispt commented Oct 17, 2022

/ocabot merge nobump

@dreispt
Copy link
Member

dreispt commented Oct 17, 2022

I think pre-commit is failing.

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 17, 2022
@OCA-git-bot
Merge PR #370 into 13.0
1967ee8 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-370-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 19, 2023
@github-actions github-actions bot closed this Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@phuctranfxvn @grindtildeath @dreispt @OCA-git-bot @rafaelbn @simahawk @asaunier @oca-travis @p-tombez