Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][mig] account mass reconcile by purchase line #212

Conversation

JordiBForgeFlow
Copy link
Member

Standard migration to 11.0

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 11.0-mig-account_mass_reconcile_by_purchase_line branch 2 times, most recently from bb1890a to 93a44a1 Compare July 13, 2018 11:20
@MiquelRForgeFlow
Copy link
Contributor

@jbeficent could you check on runbot? :)

@JordiBForgeFlow
Copy link
Member Author

@aheficent can you review?

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an error here when clicking to create a mass reconcile record on runbot.


@staticmethod
def _get_reconcilation_methods():
methods = super()._get_reconcilation_methods()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File "/home/odoo/build/OCA/bank-statement-reconcile/account_mass_reconcile/models/mass_reconcile.py", line 85, in _selection_name
return self._get_reconcilation_methods()
File "/home/odoo/build/OCA/bank-statement-reconcile/account_mass_reconcile_by_purchase_line/models/mass_reconcile.py", line 12, in _get_reconcilation_methods
methods = super()._get_reconcilation_methods()
RuntimeError: super(): no arguments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Could you try again, @aheficent ?

Copy link

@AaronHForgeFlow AaronHForgeFlow Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's wrong with runbot? I forced rebuild twice but it's never available.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 11.0-mig-account_mass_reconcile_by_purchase_line branch from 93a44a1 to 46e56d9 Compare July 23, 2018 09:42
@JordiBForgeFlow
Copy link
Member Author

@aheficent not sure what's wrong with runbot, but it's not related to this PR.

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still errored

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional tested

@JordiBForgeFlow JordiBForgeFlow merged commit 8d0146f into OCA:11.0 Jul 25, 2018
@MiquelRForgeFlow MiquelRForgeFlow deleted the 11.0-mig-account_mass_reconcile_by_purchase_line branch July 25, 2018 16:13
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 28, 2018
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants