-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][mig] account mass reconcile by purchase line #212
[11.0][mig] account mass reconcile by purchase line #212
Conversation
bb1890a
to
93a44a1
Compare
@jbeficent could you check on runbot? :) |
@aheficent can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got an error here when clicking to create a mass reconcile record on runbot.
|
||
@staticmethod | ||
def _get_reconcilation_methods(): | ||
methods = super()._get_reconcilation_methods() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File "/home/odoo/build/OCA/bank-statement-reconcile/account_mass_reconcile/models/mass_reconcile.py", line 85, in _selection_name
return self._get_reconcilation_methods()
File "/home/odoo/build/OCA/bank-statement-reconcile/account_mass_reconcile_by_purchase_line/models/mass_reconcile.py", line 12, in _get_reconcilation_methods
methods = super()._get_reconcilation_methods()
RuntimeError: super(): no arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Could you try again, @aheficent ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's wrong with runbot? I forced rebuild twice but it's never available.
93a44a1
to
46e56d9
Compare
@aheficent not sure what's wrong with runbot, but it's not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still errored
aaa5b2f
to
c21ec21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Functional tested
Standard migration to 11.0