Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [MIG] account_partner_reconcile #236

Merged
merged 6 commits into from
Apr 11, 2019
Merged

[12.0] [MIG] account_partner_reconcile #236

merged 6 commits into from
Apr 11, 2019

Conversation

bjeficent
Copy link

Bump to version 12.0

@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 17, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 17, 2018
Closed
16 tasks
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 28, 2018
Closed
8 tasks
cubells
cubells suggested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

account_partner_reconcile/__manifest__.py Outdated Show resolved Hide resolved
account_partner_reconcile/__manifest__.py Outdated Show resolved Hide resolved
account_partner_reconcile/models/res_partner.py Outdated Show resolved Hide resolved
@bjeficent bjeficent force-pushed the 12.0-mig-account_partner_reconcile branch from f0d0ebd to 045c2d9 Compare March 7, 2019 11:47
@bjeficent
Copy link
Author

Comments attended, thanks for the review.

cubells
cubells approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM

Code review and test

pniederlag
pniederlag approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@pniederlag pniederlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button is there and working like intended. code looks good to me.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit 044d44b into OCA:12.0 Apr 11, 2019
@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-mig-account_partner_reconcile branch May 21, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pniederlag pniederlag pniederlag approved these changes

@cubells cubells cubells approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
8 participants
@bjeficent @OCA-git-bot @pniederlag @cubells @pedrobaeza @JordiBForgeFlow @MiquelRForgeFlow @oca-travis