16.0 mig agreement legal #8

urvisha-serpentcs · 2023-01-13T13:15:47Z

No description provided.

sanchonuria · 2023-01-26T15:41:05Z

Can you add the commits from #9 please?

rousseldenis · 2023-02-23T13:43:38Z

/ocabot rebase

OCA-git-bot · 2023-02-23T13:43:46Z

Congratulations, PR rebased to 16.0.

rousseldenis · 2023-02-23T13:43:55Z

/ocabot migration agreement_legal

len-foss

LGTM

len-foss · 2023-05-30T10:31:54Z

Hello @ygol
Is it possible to move forward with this?

Besides the PR mentioned above, it would be nice to make the create method work in batch, split the create_agreement function into a method with only the logic and one that does the view stuff (for cleaner overrides, instead of doing self.env[res["res_model"]].browse(res["res_id"])...).

Also, comment all the settings that refer to modules that haven't been migrated, and other modules depend on this one (e.g. agreement_project).

ygol · 2023-05-30T15:34:56Z

Hello @ygol Is it possible to move forward with this?

Besides the PR mentioned above, it would be nice to make the create method work in batch, split the create_agreement function into a method with only the logic and one that does the view stuff (for cleaner overrides, instead of doing self.env[res["res_model"]].browse(res["res_id"])...).

Also, comment all the settings that refer to modules that haven't been migrated, and other modules depend on this one (e.g. agreement_project).

Hi @len-foss I believe this PR was opened by @urvisha-serpentcs . Right?

len-foss · 2023-05-30T16:17:42Z

Right, it seems the work is done so the only thing left is a maintainer review/merge the PR. Did I get something wrong?

ygol · 2023-05-31T05:55:23Z

Right, it seems the work is done so the only thing left is a maintainer review/merge the PR. Did I get something wrong?

oh no. sorry for the confusion. it just you made some recommendation/remarks in your review and I thought you asked me to address them.

rousseldenis · 2023-05-31T07:20:12Z

/ocabot rebase

[UPD] README.rst

[UPD] Update agreement_legal.pot

Translated using Weblate (French) Currently translated at 100.0% (301 of 301 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/fr/ [UPD] Update agreement_legal.pot

[UPD] Update agreement_legal.pot

[UPD] Update agreement_legal.pot Added translation using Weblate (Portuguese (Portugal))

Currently translated at 100.0% (255 of 255 strings) Translation: contract-14.0/contract-14.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement_legal/es_AR/

OCA-git-bot · 2023-05-31T07:20:20Z

Congratulations, PR rebased to 16.0.

rousseldenis · 2023-05-31T07:26:10Z

@urvisha-serpentcs Could you just put the version change in manifest.py in migration commit and not in pre-commit one ? Thanks

rousseldenis · 2023-05-31T07:42:34Z

@JayVora-SerpentCS

SkiBY · 2023-06-06T07:00:15Z

@urvisha-serpentcs there are some test cases covered in PR# you can use to increase score.

SkiBY

LGTM
Code coverage to be increased

AntoniRomera

LGTM

sanchonuria

Can you add the commits from #9 please?

len-foss · 2023-06-08T08:04:16Z

Honestly the simpler way would be to merge the PR, and then do another PR to bring #9 and/or other fixes.

@rousseldenis do you have merge rights?

rousseldenis · 2023-06-08T08:09:28Z

Honestly the simpler way would be to merge the PR, and then do another PR to bring #9 and/or other fixes.

@rousseldenis do you have merge rights?

Indeed we can do a further PR

/ocabot merge nobump

OCA-git-bot · 2023-06-08T08:09:37Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-8-by-rousseldenis-bump-nobump, awaiting test results.

len-foss · 2023-06-08T08:12:15Z

Thank you!

OCA-git-bot · 2023-06-08T08:14:30Z

Congratulations, your PR was merged at 60c97ac. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot force-pushed the 16.0-mig-agreement_legal branch from 75ce4ff to f964a66 Compare February 23, 2023 13:44

OCA-git-bot added this to the 16.0 milestone Feb 23, 2023

OCA-git-bot mentioned this pull request Feb 23, 2023

Migration to version 16.0 #4

Open

7 tasks

rousseldenis added needs review migration labels Feb 23, 2023

len-foss approved these changes May 19, 2023

View reviewed changes

ygol and others added 15 commits May 31, 2023 07:20

[ADD] agreement_legal migration

a15c3b7

[FIX] flake8

553c71f

[FIX] flake8(2)

4f23cea

[FIX] agreement_legal: remove account dependency

44efb93

[FIX] ooops

9a755dd

[UPD] README.rst

[FIX] handling code field + partner_id

d75a217

[UPD] Update agreement_legal.pot

[ADD] custom dynamic parties

279d3ac

[FIX] flake8

f99b2f0

[FIX] pylint

5c8ae51

[IMP] add default html value for parties

a468698

[UPD] flake8

d8d4186

[FIX][12.0] Menu Icon.

2fdbff4

[UPD] Update agreement_legal.pot

[FIX] Icon in settings

0c7edb6

[FIX] agreement_legal: module name

bfc460c

[UPD] Update agreement_legal.pot Added translation using Weblate (Portuguese (Portugal))

ibuioli and others added 10 commits May 31, 2023 07:20

Added translation using Weblate (Spanish (Argentina))

844a74c

Translated using Weblate (Spanish (Argentina))

31bda4c

Currently translated at 100.0% (255 of 255 strings) Translation: contract-14.0/contract-14.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement_legal/es_AR/

[MIG] agreement_legal: Migration to 15.0

3ed6e38

[IMP] agreement_legal: black, isort, prettier

c796cde

[MIG] agreement_legal: Finish migration to 15.0

008aa92

[UPD] Update agreement_legal.pot

ac98468

[UPD] README.rst

3b87eb8

[IMP] agreement_legal: pre-commit stuff

9f14116

[MIG] agreement_legal: Migration to 16.0

152d2d7

[IMP] fix pre-commit issue

ebe9fbf

OCA-git-bot force-pushed the 16.0-mig-agreement_legal branch from f964a66 to ebe9fbf Compare May 31, 2023 07:20

rousseldenis mentioned this pull request Jun 5, 2023

[16.0][mig] agreement_legal #16

Closed

SkiBY approved these changes Jun 6, 2023

View reviewed changes

OCA-git-bot added the approved label Jun 6, 2023

AntoniRomera approved these changes Jun 7, 2023

View reviewed changes

sanchonuria suggested changes Jun 8, 2023

View reviewed changes

OCA-git-bot removed the approved label Jun 8, 2023

OCA-git-bot added the bot is merging ⏳ label Jun 8, 2023

OCA-git-bot merged commit 7cbcd00 into OCA:16.0 Jun 8, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16.0 mig agreement legal #8

16.0 mig agreement legal #8

urvisha-serpentcs commented Jan 13, 2023

sanchonuria commented Jan 26, 2023

rousseldenis commented Feb 23, 2023

OCA-git-bot commented Feb 23, 2023

rousseldenis commented Feb 23, 2023

len-foss left a comment

len-foss commented May 30, 2023

ygol commented May 30, 2023

len-foss commented May 30, 2023

ygol commented May 31, 2023

rousseldenis commented May 31, 2023

OCA-git-bot commented May 31, 2023

rousseldenis commented May 31, 2023

rousseldenis commented May 31, 2023

SkiBY commented Jun 6, 2023

SkiBY left a comment

AntoniRomera left a comment

sanchonuria left a comment

len-foss commented Jun 8, 2023

rousseldenis commented Jun 8, 2023

OCA-git-bot commented Jun 8, 2023

len-foss commented Jun 8, 2023

OCA-git-bot commented Jun 8, 2023

16.0 mig agreement legal #8

16.0 mig agreement legal #8

Conversation

urvisha-serpentcs commented Jan 13, 2023

sanchonuria commented Jan 26, 2023

rousseldenis commented Feb 23, 2023

OCA-git-bot commented Feb 23, 2023

rousseldenis commented Feb 23, 2023

len-foss left a comment

Choose a reason for hiding this comment

len-foss commented May 30, 2023

ygol commented May 30, 2023

len-foss commented May 30, 2023

ygol commented May 31, 2023

rousseldenis commented May 31, 2023

OCA-git-bot commented May 31, 2023

rousseldenis commented May 31, 2023

rousseldenis commented May 31, 2023

SkiBY commented Jun 6, 2023

SkiBY left a comment

Choose a reason for hiding this comment

AntoniRomera left a comment

Choose a reason for hiding this comment

sanchonuria left a comment

Choose a reason for hiding this comment

len-foss commented Jun 8, 2023

rousseldenis commented Jun 8, 2023

OCA-git-bot commented Jun 8, 2023

len-foss commented Jun 8, 2023

OCA-git-bot commented Jun 8, 2023